Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add places api v1 #529

Merged
merged 1 commit into from
Oct 15, 2024
Merged

chore: add places api v1 #529

merged 1 commit into from
Oct 15, 2024

Conversation

b0xtch
Copy link
Contributor

@b0xtch b0xtch commented Oct 15, 2024

Add support for places api

@Byron Byron linked an issue Oct 15, 2024 that may be closed by this pull request
@Byron Byron merged commit a3660b7 into Byron:main Oct 15, 2024
5 of 6 checks passed
@Byron
Copy link
Owner

Byron commented Oct 15, 2024

Thanks a lot!

@b0xtch
Copy link
Contributor Author

b0xtch commented Oct 15, 2024

Thanks a lot!

ofc qq on the publishing I am not sure what the procedure is! should I publish? I don't see it in the CI either

@Byron
Copy link
Owner

Byron commented Oct 15, 2024

No, please don't publish it.

It doesn't show in CI as CI only tests a small subset of APIs and CLIs - otherwise it would never finish.

I will re-publish the crates in the coming days (it was also requested elsewhere).

@b0xtch
Copy link
Contributor Author

b0xtch commented Oct 15, 2024

No, please don't publish it.

It doesn't show in CI as CI only tests a small subset of APIs and CLIs - otherwise it would never finish.

I will re-publish the crates in the coming days (it was also requested elsewhere).

you got it, thanks 🙏

@b0xtch b0xtch deleted the feat/places-api branch October 16, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support: is google places api supported?
2 participants