Add DistributedTopology2D
#373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpamnany
force-pushed
the
kp/dtopo
branch
3 times, most recently
from
f26d199 to
562ea38
Compare
simonbyrne
reviewed
Dec 22, 2021
9 tasks
kpamnany
force-pushed
the
kp/dtopo
branch
2 times, most recently
from
773caa4 to
444fb20
Compare
simonbyrne
reviewed
Jan 25, 2022
simonbyrne
reviewed
Jan 25, 2022
sriharshakandala
force-pushed
the
kp/dtopo
branch
2 times, most recently
from
b1e5f69 to
bbfe6fc
Compare
simonbyrne
approved these changes
Jan 25, 2022
simonbyrne
reviewed
Jan 25, 2022
sriharshakandala
force-pushed
the
kp/dtopo
branch
from
bbfe6fc to
f8d99a7
Compare
sriharshakandala
force-pushed
the
kp/dtopo
branch
from
f8d99a7 to
347e0d1
Compare
bors bot
added a commit
that referenced
this pull request
Jan 26, 2022
473: drop 1.6 support, add nightly tests r=simonbyrne a=simonbyrne Since ClimaComms is 1.7 only, we can't merge #373. Given performance issues on 1.6, it isn't worth supporting. Co-authored-by: Simon Byrne <[email protected]>
sriharshakandala
force-pushed
the
kp/dtopo
branch
from
1bd8b5c to
651a6bc
Compare
Add `DistributedTopology2D` Add distributed dss functionality and tests for scalar and vector fields. revereted examples Applied formatter. Co-authored-by: sriharshakandala <[email protected]>
sriharshakandala
force-pushed
the
kp/dtopo
branch
from
651a6bc to
251494c
Compare
sriharshakandala
force-pushed
the
kp/dtopo
branch
2 times, most recently
from
010046f to
b68b9e3
Compare
sriharshakandala
force-pushed
the
kp/dtopo
branch
from
b68b9e3 to
60961cb
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 28, 2022
373: Add `DistributedTopology2D` r=sriharshakandala a=kpamnany Closes #323. - [X] Integrates `ClimaComms.jl` - [X] Adds `DistributedTopology2D` and unit tests - [X] Updates `SpectralElementSpace2D` to support a distributed topology - [X] Adds a `dss_2d!` for a distributed topology and unit tests Some comments: - Move/rename `Spaces.setup_comms` to something sensible - Multiple comments are tagged with `XXX` for reviewer consideration - DSS performance can be improved by changing `ghost_faces` and `ghost_vertices` to store useful indices (such as the neighbor index) - Names (of files, types and functions) need to be reconsidered (`internal_vertices` or `interior_vertices`? `local_elems` or `real_elems`? etc.) This is squashed and tests pass locally so it's ready to merge once `ClimaComms` is [registered](JuliaRegistries/General#52941). Cc: `@sriharshakandala` Co-authored-by: K Pamnany <[email protected]> Co-authored-by: Sriharsha Kandala <[email protected]>
|
Build failed: |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #323.
ClimaComms.jlDistributedTopology2Dand unit testsSpectralElementSpace2Dto support a distributed topologydss_2d!for a distributed topology and unit testsSome comments:
Spaces.setup_commsto something sensibleXXXfor reviewer considerationghost_facesandghost_verticesto store useful indices (such as the neighbor index)internal_verticesorinterior_vertices?local_elemsorreal_elems? etc.)This is squashed and tests pass locally so it's ready to merge once
ClimaCommsis registered.Cc: @sriharshakandala