-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Async Support #276
Merged
Merged
Add Async Support #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feat-async
…into feat-async
The previous comment here indicated we saved the handle to keep the task alive, but the docs for `JoinHandle` specifically say that a drop detaches the handle from the task. It does not kill the task.
Just ConnectionMethods trait for now. More to come.
Sqlite compilation re-enabled but sqlite not enabled in tests yet Still need to: - A bunch of TODOs - Sqlite tests - Sync tests - remove ?Send bound from async-trait. This may be tricky, but I believe it's required for the tokio rt executor. - Clean up sync naming - Clippy lints
New Rust 1.82 lint rust-lang/rust#129207
|
Note that elided_named_lifetimes is only present on nightly and not on stable, hence why we allow it explicitly when invoking nightly rustdoc rather than more generally.
Avoid the proc-macro-error dependency which fails cargo-deny due to https://rustsec.org/advisories/RUSTSEC-2024-0370
jayvdb
reviewed
Oct 27, 2024
jayvdb
reviewed
Oct 27, 2024
jayvdb
approved these changes
Oct 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two previous comments; but lgtm
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add async support. There are still a few outstanding gaps and potential issues which are tracked in async_checklist.md. We'll wait to release 0.8 for those to be resolved.
Addresses #13