Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require async feature for doctests and mosts tests #293

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

jayvdb
Copy link
Collaborator

@jayvdb jayvdb commented Jan 7, 2025

Closes #292

@jayvdb jayvdb force-pushed the butane-test-fix branch 3 times, most recently from c7872f9 to 0c943e1 Compare January 7, 2025 23:42
@jayvdb
Copy link
Collaborator Author

jayvdb commented Jan 8, 2025

The alternative is to add the following

diff --git a/butane/Cargo.toml b/butane/Cargo.toml
index 6487f64..4184a54 100644
--- a/butane/Cargo.toml
+++ b/butane/Cargo.toml
@@ -36,6 +36,7 @@ r2d2 = { optional = true, workspace = true }
 deadpool = { optional = true, workspace = true }

 [dev-dependencies]
+butane = { workspace = true, features = ["async"] }
 butane_test_helper = { workspace = true }
 butane_test_macros = { workspace = true }
 cfg-if = { workspace = true }

happy to do that, if it is preferred.

@jayvdb jayvdb marked this pull request as ready for review January 8, 2025 00:35
@Electron100
Copy link
Owner

I'm merging this as a short-term measure but I'd like to leave the issue open because something seems fishy here. The way the test and product macros are written, they should skip generating or requiring any of the async stuff if async isn't enabled. So I worry this could be masking a real bug. Or at the very least I'd like to better understand and document what's going on. I'll try to take a closer look tomorrow.

@Electron100 Electron100 merged commit d7cd49b into Electron100:master Jan 9, 2025
4 checks passed
@jayvdb jayvdb deleted the butane-test-fix branch January 9, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running butane tests fail unless async feature is enabled
2 participants