Add support for context parallelism #1299
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bclyang
force-pushed
the
add-context-parallel-support
branch
2 times, most recently
from
2b0bd92 to
7f168f0
Compare
|
|
bclyang
force-pushed
the
add-context-parallel-support
branch
from
7f168f0 to
4969683
Compare
| @@ -37,7 +37,7 @@ def __init__( | |||
| normalized_shape, | |||
| eps=1e-5, | |||
| no_persist_layer_norm=True, | |||
| sequence_parallel=False, | |||
There was a problem hiding this comment.
@bclyang -- Shouldn't these remain sequence_parallel to match our previous support for megatron-style sequence parallelism (essentially just TP applied to layernorm and dropout)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds context parallelism with ring attention.
See WandB report for training runs to test correctness with a simple 410M config: https://wandb.ai/brandony/neox/reports/Test-context-parallelism-correctness--Vmlldzo5NTU4ODc1.
Based on this initial PR: #1266, with changes to get things working: