Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations from CrowdIn #463

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Conversation

hasecilu
Copy link
Contributor

A question, did you make a tweak on CrowdIn to make the Render files be separated in a folder when downloading the ZIP? All other files were separated by locale.

Filename Translated Messages
Render_es-AR.ts 228
Render_es-ES.ts 228
Render_fr.ts 228
Render_pl.ts 77
Render_sl.ts 46
Render_ka.ts 37
Render_de.ts 31
Render_it.ts 24

- Use `lupdate` from Qt6

The previous way on which the files were updated is done is by creating
some temporal files and then merging them to the original file.

Doing this merge would let us to NOT lost the translations already done.

It was done like that because we got the string from Python files and UI
files because `lupdate` from Qt5 couldn't extract strings from Python
files.

Now the `lupdate` from Qt6 can do, so we have no need to merge different
temp files, instead, we can do the update in a single command.

The new advantage is that the `<location>` tag is updated with all new
occurrences.
@howetuft
Copy link
Collaborator

Hello,
Thank you for the translations! I actually tweaked Crowdin when I initialized it for Render... but I can't remember what I did exactly. Is the current behavior a problem?

@howetuft howetuft merged commit 44b6d44 into FreeCAD:master Nov 26, 2024
3 checks passed
@hasecilu
Copy link
Contributor Author

Hello,
Thank you for the translations! I actually tweaked Crowdin when I initialized it for Render... but I can't remember what I did exactly. Is the current behavior a problem?

The opposite actually, for all other WB I had to make a script to group the files from the same WB.

The only drawback is that it adds those extra chars in the filename (fr-FR vs fr), different from what FreeCAD uses.

@howetuft
Copy link
Collaborator

Oh, I think I remember:
Go to Sources and open the settings of the workbench (the 3 dots on the right, and then the 'Settings' entry):
1732595737

All the magic is in the 'Resulting file after translation export':

1732595879

@hasecilu
Copy link
Contributor Author

Cool, I made the change for the other WB, now they're grouped by project.

@hasecilu hasecilu deleted the i18n/update branch November 26, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants