Add rgsl-nlinear library to rust-GSL. #159
Conversation
rgsl-nlinear/Cargo.toml
Outdated
| @@ -0,0 +1,15 @@ | |||
| [package] | |||
There was a problem hiding this comment.
Why did you create this new crate?
There was a problem hiding this comment.
I wasn't sure if you wanted rust-GSL to be pure Rust or not. It could easily be combined with the Rust-GSL crate.
There was a problem hiding this comment.
I want it to remain pure Rust indeed. But then, why do you need this C code?
There was a problem hiding this comment.
So I'm posting a link to an issue comment that I submitted a few weeks ago:
I had trouble setting the default parameters in Rust using just the GSL-sys library. All the function does is return a struct, but the struct, written in C, returns other substructs, some of which contain references to C functions. I think this is what is causing Bus errors and Segmentation faults when setting the default parameters.
I haven't been able to find a resolution to this, but if I can get past this, it takes me a little closer to fully implementing it in Rust.
There was a problem hiding this comment.
Would be better to fix the issue rather than trying to rewrite some code in C.
There was a problem hiding this comment.
Agreed. However, I only have about a month of Rust under my belt. I just got the rgsl-nlinear crate to work how I would expect it to work, and I have the feeling that this issue is beyond my current level of expertise, but I have some ideas on a way forward.
There was a problem hiding this comment.
I figured out a workaround to the issue that I was experiencing and have rewritten the crate in Rust. Please let me know if I can resolve this conversation.
There was a problem hiding this comment.
It looks much better. But I'm still not sure why it's creating a new crate.
gslsys-mfnlin/src/lib.rs
Outdated
| @@ -0,0 +1,361 @@ | |||
| // | |||
There was a problem hiding this comment.
Why not making this part of the main sys crate?
There was a problem hiding this comment.
I made it into a separate create because you have gsl-* in .gitignore. I went ahead and removed gslsys-mfnlin from the repo.
examples/multifit_nlinear.rs
Outdated
| use rgsl::types::rng::RngType; | ||
|
|
||
|
|
||
| #[no_mangle] |
There was a problem hiding this comment.
There is no need or no_mangle in here.
Added rgsl::multifit_nlinear::gsl_multifit_nlinear_basic and rgsl::multifit_nlinear::gsl_multifit_nlinear_basic_df functions to rgsl library.