Ebauche: Comment avoir une jolie c-enum typesafe en Rust. #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Aurelia <[email protected]>
AureliaDolo
reviewed
Jun 24, 2024
|
|
||
| Cependant avec cette approche notre type Qtype a cause du variant `Qtype::Unknown(u16)` aura une taille de | ||
| `4` bytes (un u32) au lieu de 2 bytes (u16)! | ||
| En effet les enums sont compilées actuellement en tagged-unions et il faut un peu de place pour le tag |
There was a problem hiding this comment.
Est-ce que tu peux faire le schéma qui montre la place prise par le tag ? vs ce que ça fait quand ya pas le unknown type dans l'enum ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@GuillaumeGomez / @AureliaDolo au secours il y a trop de fautes.
EDIT: je fix le msg de la PR apres les premiers retours. :P
TODO