-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markup 2020 additional edits #1858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this.
We cannot put this live yet as it introduces errors with the table header changes. Not only would this actually falsify the information (notably occurrences ≠ pages), it also comes with a cost of at least two more people needing to review both the data and the changes (precisely because there is a big need to be precise, and a good risk—just being confirmed—that a header/label change is inaccurate). I’d stay away from this—or at least reach out ahead of time to work with two people from the team to see who has time and then to prepare these edits together.
@j9t you happy to merge this? think I addressed all the concerns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bazzadp, also @Tiggerito, @iandevlin.
While completing the Dutch translation of this chapter we noticed there were a few TODOs that were not closed out one way or another (as "fixed" or "won't do").
I've reviewed them all and think the biggest issue is the use of "Occurrences" in tables to sometimes mean pages and sometimes mean elements, which is confusing and therefore leaves open misinterpretation.
So I made some fixes to address the outstanding TODOs, and also changed a few other phrasings I still found difficult to understand on a read through (though it's a million times better than my German or Romanian would be, so please don't take that as an insult!).
I realise this chapter was lucky enough to be the first to be edited, so it's had a lot of scrutiny already, and another round of edits might be the last thing you want to see, but think it's best to close out these remaining issues as do think this is a valuable resource that people will depend on until the 2021 edition comes along - and even thereafter. So if you could just spend one more time ensuring you're comfortable with these edits that would be greatly appreciated!
Progress on #899 #1432