Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Hbc::Container::Gpg. #4534

Merged
merged 1 commit into from
Jul 23, 2018

Conversation

reitermarkus
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Given the discussion in #4120 and this not being used by any cask, let's just remove it.

@reitermarkus reitermarkus requested review from a team July 22, 2018 19:27
@ghost ghost assigned reitermarkus Jul 22, 2018
@ghost ghost added the in progress Maintainers are working on this label Jul 22, 2018
@reitermarkus reitermarkus force-pushed the remove-gpg-container branch from 57fc166 to 27c70c6 Compare July 22, 2018 19:56
@claui
Copy link
Contributor

claui commented Jul 23, 2018

this not being used by any cask

Are you referring to the gpg stanza?

This is what I’ve found in homebrew-cask:

$ grep -R --include='*.rb' '^\s*gpg\s' Casks     # in homebrew-cask
Casks/litecoin.rb:  gpg "#{url}.asc", key_id: 'fe3348877809386c'
Casks/vlc.rb:  gpg "#{url}.asc", key_id: '65f7c6b4206bd057a7eb73787180713be58d1adc'
Casks/libreoffice.rb:  gpg "#{url}.asc", key_id: 'c2839ecad9408fbe9531c3e9f434a1efafeeaea3'
Casks/espionage.rb:  gpg "#{url}.sig", key_url: 'https://www.taoeffect.com/other/A884B988.asc'
Casks/1password-cli.rb:  gpg 'op.sig', key_url: 'https://keybase.io/1password/pgp_keys.asc'
Casks/filebot.rb:  gpg "#{url}.asc", key_url: 'https://raw.githubusercontent.com/filebot/plugins/master/gpg/maintainer.pub'
Casks/keepassxc.rb:  gpg "#{url}.sig", key_url: 'https://keepassxc.org/keepassxc_master_signing_key.asc'
Casks/copay.rb:  gpg "#{url}.sig", key_id: '9d17e656bb3b6163ae9d71725cd600a61112cfa1'
Casks/lyx.rb:  gpg "#{url}.sig", key_id: 'de7a44fac7fb382d'
Casks/jameica.rb:  gpg "#{url}.asc", key_id: '5a8ed9cfc0db6c70'
Casks/pgadmin4.rb:  gpg "#{url}.sig", key_id: 'e0c4ceeb826b1fda4fb468e024adfaaf698f1519'
Casks/metasploit.rb:  gpg "#{url}.asc", key_id: '2007B954'
Casks/bisq.rb:  gpg "#{url}.asc", key_id: '1dc3c8c4316a698ac494039cf5b84436f379a1c6'
Casks/onionshare.rb:  gpg "#{url}.sig", key_url: 'https://onionshare.org/signing-key.asc'
Casks/ricochet.rb:  gpg "#{url}.asc", key_id: '9032cae4cbfa933a5a2145d5ff97c53f183c045d'
Casks/gpg-suite.rb:  gpg "#{url}.sig", key_url: 'https://gpgtools.org/GPGTools-00D026C4.asc'
Casks/mysqlworkbench.rb:  gpg "#{url}.asc", key_id: '8c718d3b5072e1f5'
Casks/mullvadvpn.rb:  gpg "#{url}.asc", key_id: 'a1198702fc3e0a09a9ae5b75d5a1d4f266de8ddf'
Casks/electrum.rb:  gpg "#{url}.asc", key_id: '6694d8de7be8ee5631bed9502bd5824b7f9470e6'
Casks/libreoffice-language-pack.rb:  gpg "#{url}.asc", key_id: 'c2839ecad9408fbe9531c3e9f434a1efafeeaea3'
Casks/electrum-ltc.rb:  gpg "#{url}.asc", key_id: 'CAE1092AD3553FFD21C05DE36FC4C9F7F1BE8FEA'
Casks/bitpay.rb:  gpg "#{url}.sig", key_id: '9d17e656bb3b6163ae9d71725cd600a61112cfa1'
Casks/tunnelblick.rb:  gpg "#{url}.asc", key_id: '76df975a1c5642774fb09868ff5fd80e6bb9367e'
Casks/torbrowser.rb:  gpg "#{url}.asc", key_id: 'ef6e286dda85ea2a4ba7de684e2c6e8793298290'
Casks/borgbackup.rb:  gpg "#{url}.asc", key_id: '51F78E01'
Casks/mumble.rb:  gpg "#{url}.sig", key_url: 'https://github.com/mumble-voip/mumble-gpg-signatures/raw/master/mumble-auto-build-2017.asc'

And in homebrew-cask-versions:

$ grep -R --include='*.rb' '^\s*gpg\s' Casks
Casks/libreoffice-still.rb:  gpg "#{url}.asc", key_id: 'c2839ecad9408fbe9531c3e9f434a1efafeeaea3'
Casks/gpg-suite-nightly.rb:  gpg "#{url}.sig", key_url: 'https://gpgtools.org/GPGTools-00D026C4.asc'
Casks/mullvad-vpn-beta.rb:  gpg "#{url}.asc", key_id: 'a1198702fc3e0a09a9ae5b75d5a1d4f266de8ddf'
Casks/pgadmin3.rb:  gpg "#{url}.sig", key_id: 'e0c4ceeb826b1fda4fb468e024adfaaf698f1519'
Casks/tor-browser-alpha.rb:  gpg "#{url}.asc", key_id: 'ef6e286dda85ea2a4ba7de684e2c6e8793298290'
Casks/libreoffice-rc.rb:  gpg "#{url}.asc", key_id: 'c2839ecad9408fbe9531c3e9f434a1efafeeaea3'
Casks/libreofficedev.rb:  gpg "#{url}.asc", key_id: 'c2839ecad9408fbe9531c3e9f434a1efafeeaea3'
Casks/multibit-classic.rb:  gpg "#{url}.asc", key_id: '23f7fb7b'
Casks/tunnelblick-beta.rb:  gpg "#{url}.asc", key_id: '76df975a1c5642774fb09868ff5fd80e6bb9367e'

@reitermarkus
Copy link
Member Author

Are you referring to the gpg stanza?

No, this is the GPG container, which would be used to extract a GPG archive.

@reitermarkus reitermarkus force-pushed the remove-gpg-container branch from 27c70c6 to b7eb7e4 Compare July 23, 2018 17:35
@reitermarkus reitermarkus merged commit 2c9dc62 into Homebrew:master Jul 23, 2018
@reitermarkus reitermarkus deleted the remove-gpg-container branch July 23, 2018 18:59
@ghost ghost removed the in progress Maintainers are working on this label Jul 23, 2018
@lock lock bot added the outdated PR was locked due to age label Aug 22, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants