Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate gpg stanza. #4768

Merged
merged 1 commit into from
Sep 3, 2018
Merged

Deprecate gpg stanza. #4768

merged 1 commit into from
Sep 3, 2018

Conversation

reitermarkus
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

As per the discussion in #4120, remove the gpg stanza. Needs matching PRs in the cask taps first.

@reitermarkus reitermarkus requested a review from a team August 27, 2018 23:58
@ghost ghost assigned reitermarkus Aug 27, 2018
@ghost ghost added the in progress Maintainers are working on this label Aug 27, 2018
MikeMcQuaid
MikeMcQuaid approved these changes Aug 28, 2018
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+19,−327 😎

This was referenced Aug 28, 2018
Merged
Merged
Merged
@reitermarkus reitermarkus force-pushed the deprecate-gpg-stanza branch 3 times, most recently from f5da469 to f4b32e7 Compare September 3, 2018 05:02
@reitermarkus reitermarkus merged commit 654ad46 into Homebrew:master Sep 3, 2018
@reitermarkus reitermarkus deleted the deprecate-gpg-stanza branch September 3, 2018 19:21
@ghost ghost removed the in progress Maintainers are working on this label Sep 3, 2018
@lock lock bot added the outdated PR was locked due to age label Oct 3, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@commitay commitay commitay approved these changes

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees

@reitermarkus reitermarkus

Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reitermarkus @MikeMcQuaid @commitay