wl: Support multiple wl_seats #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psaavedra
changed the title
psaavedra
force-pushed
the
psaavedra/main-refactorings-623
branch
12 times, most recently
from
8e70423 to
bce7a5c
Compare
psaavedra
changed the title
psaavedra
force-pushed
the
psaavedra/main-refactorings-623
branch
3 times, most recently
from
7bd5ce4 to
d3d5479
Compare
psaavedra
force-pushed
the
psaavedra/main-refactorings-623
branch
2 times, most recently
from
47e331a to
a321b21
Compare
aperezdc
requested changes
Oct 31, 2023
psaavedra
commented
Oct 31, 2023
Wrap the creation and destruction of a Wayland display inside of the cog_wl_display_create() and cog_wl_display_destroy() functions and move these to cog-utils-wl.
psaavedra
force-pushed
the
psaavedra/main-refactorings-623
branch
from
a321b21 to
a43b0fc
Compare
aperezdc
approved these changes
Oct 31, 2023
A CogWlDisplay contains a default seat. This default value is the first seat registered and hereafter the last one activated. This is used for the shell_popup_surface and for the on_mouse_target_changed handlers. The CogWlDisplay also contains the rest of the CogWlPlatform in a list. This patch also fixes the tracking of the serials for the input methods. Now each different kind of input method for each Seat is stored individually and updated according. Still it is possible to get the latest serial using the suitable cog_wl_seat_get_serial() function. Some code was cleaned-up and relocated in cot-utils-wl as functions: cog_wl_display_add_seat; cog_wl_seat_create(); cog_wl_seat_destroy(); void cog_wl_text_input_clear(); cog_wl_text_input_set()
psaavedra
force-pushed
the
psaavedra/main-refactorings-623
branch
from
a43b0fc to
5896b0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extend the WL platform to support more than one WL Seat registered to the Cog app.
Now the CogWlDisplay contains a default seat. This is the first registered and then the last seat activated. This is used for the shell_popup_surface and for the on_mouse_target_changed handlers. The CogWlDisplay also contains the rest of the CogWlPlatform in a list.
The listeners associated to input methods (pointer, keyboard and touch) now pass the CogWlSeat as contextual information to the callbacks. The CogWlPlatform object is still accessible because this is attached as user_data to the wl_surface on creation time and associated to the seats as [pointer|keyboard|touch]_target then the input event is activated. These also updates what is the default seat.
This patch also fixes the tracking of the serials for the input methods. Now each different kind of input method for each Seat is stored individually and updated according. Still it is possible to get the latest serial using the suitable cog_wl_seat_get_serial() function.
Some other code was cleaned-up and relocated in cot-utils-wl as functions:
cog_wl_display_add_seat; cog_wl_seat_create(); cog_wl_seat_destroy(); void cog_wl_text_input_clear(); cog_wl_text_input_set().Also CogWlDisplay create/destroy logic is wrapped inside of the cog_wl_display_create() and cog_wl_display_destroy() functions and move these to cog-utils-wl.