wl: Make setting surface sizes more robust #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the code that determines the initial Wayland surface size to cog_wl_platform_init(), to ensure it is done only once during instantiation of CogWlPlatform. There is no need to read and validate environment variables every time the surface geometry is configured. While at it, factor out reading and validating values from environment variables into a getenv_uint32() utility function.
Add safeguards to ensure a zero size is never used to configure the Wayland surface geometry.
aperezdc
force-pushed
the
aperezdc/fixes
branch
from
44a0177 to
939d3bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two commits which improve robustness when handling setting Wayland surface sizes:
COG_PLATFORM_WL_VIEW_{WIDTH,HEIGHT}environment variables only once during instantiation of theCogWlPlatforminstance. There is no need to read those every time the surface is resized. This also brings in a helper function to do more thorough validation of the values from the environment variables.g_return_if_fail()to check that the width and height passed tocog_wl_platform_configure_geometry()are non-zero.