wl: Fix possible invalid access to Platform:popup #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psaavedra
force-pushed
the
psaavedra/main-refactorings-624-fix-leak
branch
from
c6a82e5 to
1e1c5a2
Compare
psaavedra
force-pushed
the
psaavedra/main-refactorings-624-fix-leak
branch
from
1e1c5a2 to
cbb4676
Compare
... inducted by the the xdg_popup::popup_done handler. This change fixes the `xdg_popup_on_popup_done()` in platform/wayland/cog-utils-wl.c. Now, the function resets the the Platform::popup if the destroyed popup is the same than the one referenced in the Platform.
psaavedra
force-pushed
the
psaavedra/main-refactorings-624-fix-leak
branch
from
cbb4676 to
32c8c80
Compare
psaavedra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... inducted by the the xdg_popup::popup_done handler.
This change fixes the
xdg_popup_on_popup_done()inplatform/wayland/cog-utils-wl.c. Now, the function resets the thePlatform::popupif the destroyed popup is the same than the onereferenced in the Platform.