platform: Bump libwpe requirement to 1.14 #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aperezdc
force-pushed
the
aperezdc/bump-libwpe
branch
from
0874083 to
bc2a51b
Compare
|
Ping reviewers 🏓 |
psaavedra
reviewed
Mar 7, 2024
psaavedra
reviewed
Mar 7, 2024
platform/wayland/cog-utils-wl.h
Outdated
| # define HAVE_SHM_EXPORTED_BUFFER WPE_FDO_CHECK_VERSION(1, 9, 0) | ||
| # define HAVE_FULLSCREEN_HANDLING WPE_FDO_CHECK_VERSION(1, 11, 1) | ||
| #else | ||
| # define HAVE_SHM_EXPORTED_BUFFER 0 |
There was a problem hiding this comment.
and similar thing here:
aperezdc/bump-libwpe psaavedra@golpe ~/local/git/WPEBackend-fdo $ grep -r HAVE_SHM_EXPORTED_BUFFER *
platform/drm/cog-platform-drm.c:# define HAVE_SHM_EXPORTED_BUFFER WPE_FDO_CHECK_VERSION(1, 9, 0)
platform/drm/cog-platform-drm.c:# define HAVE_SHM_EXPORTED_BUFFER 0
aperezdc
force-pushed
the
aperezdc/bump-libwpe
branch
from
bc2a51b to
3f9a8b4
Compare
aperezdc
force-pushed
the
aperezdc/bump-libwpe
branch
from
3f9a8b4 to
9af0922
Compare
Bump required libwpe version to 1.14.0, which allows dropping conditional compilation for setting target refresh rates. Always building the code reduces the testing matrix, and version 1.14.0 is over a year old so the change should not pose any issue for packagers.
aperezdc
force-pushed
the
aperezdc/bump-libwpe
branch
from
9af0922 to
c12bf19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump required libwpe version to 1.14.0, which allows dropping conditional compilation for setting target refresh rates. Always building the code reduces the testing matrix, and version 1.14.0 is over a year old so the change should not pose any issue for packagers.