Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk4: set focused activity state based on window::is-active #725

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

cadubentzen
Copy link
Contributor

Without the wpe_view_activity_state_focused flag, gamepad events aren't forwarded to the view.

This change is aligned with what is done in GTK port [1].

[1] https://commits.webkit.org/273882@main.

Copy link
Member

@TingPing TingPing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Code style check failed though.

@cadubentzen
Copy link
Contributor Author

LGTM

Code style check failed though.

fixed it 👍

@philn
Copy link
Member

philn commented Aug 2, 2024

Failed again, only one diff remaining!

Without the wpe_view_activity_state_focused flag, gamepad events
aren't forwarded to the view.

This change is aligned with what is done in GTK port [1].

[1] https://commits.webkit.org/273882@main.
@philn philn merged commit 9ac900a into Igalia:master Aug 3, 2024
5 checks passed
@cadubentzen cadubentzen deleted the gtk4-is-focused branch August 3, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants