Typing fixes

Jonxslays · Nov 26, 2023 · d15e123 · d15e123
1 parent 5641e15
commit d15e123
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/wom/serializer.py b/wom/serializer.py
@@ -1162,9 +1162,10 @@ def deserialize_group_activity(self, data: DictT) -> models.GroupActivity:
 
     @serializer_guard
     def deserialize_social_links(self, data: DictT) -> models.SocialLinks:
-        links = models.SocialLinks()
-        self._set_attrs(
-            links, data, "website", "discord", "twitter", "youtube", "twitch", maybe=True
+        return models.SocialLinks(
+            website=data.get("website"),
+            discord=data.get("discord"),
+            youtube=data.get("youtube"),
+            twitter=data.get("twitter"),
+            twitch=data.get("twitch"),
         )
-
-        return links
diff --git a/wom/services/base.py b/wom/services/base.py
@@ -48,7 +48,7 @@ def __init__(self, http_service: HttpService, serializer: serializer.Serializer)
         self._http = http_service
         self._serializer = serializer
         self._dict = t.Dict[str, t.Any]
-        self._list = t.List[self._dict]
+        self._list = t.List[t.Dict[str, t.Any]]
 
     def _generate_map(self, **kwargs: t.Any) -> t.Dict[str, t.Any]:
         return {k: v for k, v in kwargs.items() if v is not None}