Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing spaces, fixed example code. #36

Merged
merged 3 commits into from
Nov 12, 2023
Merged

Conversation

Faabvk
Copy link
Contributor

@Faabvk Faabvk commented Nov 11, 2023

Several fixes to the documentation as requested in #35

  • Added missing spaces to the explanation of the description argument in create_group() and edit_group()
  • Fixed example code
    • create_group() and edit_group(): Made it so GroupMemberFragment objects are passed instead of strings, which would not work.
    • add_members(): GroupMemberFragments were already used here, but they weren't declared correctly when compared to the way wom.py is imported

This PR is to just fix the issues, intending to have another PR to actually allow strings to be passed as group members.

wom/services/groups.py Outdated Show resolved Hide resolved
wom/services/groups.py Outdated Show resolved Hide resolved
wom/services/groups.py Outdated Show resolved Hide resolved
wom/services/groups.py Outdated Show resolved Hide resolved
@Faabvk Faabvk requested a review from Jonxslays November 12, 2023 19:35
wom/services/groups.py Outdated Show resolved Hide resolved
@Faabvk Faabvk requested a review from Jonxslays November 12, 2023 20:43
Copy link
Owner

@Jonxslays Jonxslays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks for the contribution! ❤️

@Jonxslays Jonxslays merged commit 73b3b3f into Jonxslays:master Nov 12, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants