Use GPUArrays caching allocator #2593
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
maleadt
force-pushed
the
master
branch
15 times, most recently
from
5d585c4 to
c850163
Compare
maleadt
reviewed
Jan 6, 2025
src/array.jl
Outdated
Comment on lines
82
to
84
| # Do not use caching allocator if it is not set or | ||
| # the buffer is not a device memory. | ||
| return if !(M <: DeviceMemory) || name == :none |
There was a problem hiding this comment.
I take it you're only caching device memory because the cache doesn't differentiate between memory types and could thus return the wrong array? Would it be possible to resolve that by including the array type in the key, or do you want to be able to alias e.g. a [1, 100] and [10, 10] array?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: JuliaGPU/GPUArrays.jl#576