Merge 1.0-dev into master #567
Conversation
1.0-dev: Remove `@format`
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #567 +/- ##
==========================================
- Coverage 90.20% 84.70% -5.50%
==========================================
Files 25 33 +8
Lines 1827 1818 -9
==========================================
- Hits 1648 1540 -108
- Misses 179 278 +99
☔ View full report in Codecov by Sentry. |
|
The CI is not passing because the new display mechanism does not work exactly the same for Julia 1.6. For the time being, since the next Julia LTS may be out soon enough, what if we require Julia 1.8 on the CI? In which case we may also want to modify the compat entry in Project.toml. |
|
Why does it work on Julia 1.0 though ? x) I'm removing 1.0 and checking if Compat.jl easily solve our problem to keep 1.6 for now. EDIT: Okay I will have to test it locally first, but that seems feasible. |
|
@Kolaru I will have more time from Tuesday on; I'll have a look on this PR then. |
| @@ -12,7 +12,6 @@ jobs: | |||
| matrix: | |||
| version: | |||
| - '1.6' | |||
| - '1' | |||
There was a problem hiding this comment.
I suggest to have back this (erased) line, so we can test also Julia 1.9 as well. (I may have been who removed it...)
Project.toml
Outdated
| @@ -1,10 +1,12 @@ | |||
| name = "IntervalArithmetic" | |||
| uuid = "d1acc4aa-44c8-5952-acd4-ba5d80a2a253" | |||
| repo = "https://github.com/JuliaIntervals/IntervalArithmetic.jl.git" | |||
| version = "0.20.8" | |||
| version = "1.0.0" | |||
There was a problem hiding this comment.
I think it was agreed to have this as 0.21.0 version...; see this comment.
| RecipesBase = "1.0" | ||
| RoundingEmulator = "0.2" | ||
| SetRounding = "0.2" | ||
| StaticArrays = "0.8, 0.9, 0.10, 0.11, 0.12, 1.0" | ||
| julia = "1.5" | ||
| StaticArrays = "1.0" |
There was a problem hiding this comment.
I think this constrains to versions of the form 1.0.x... Current version of StaticArrays is v1.6.0. A similar comment applies to Polynomials, and CRlibm.
There was a problem hiding this comment.
1.0 is the same as 1 and stands for the interval [1.0.0, 2.0.0).
Source; note that the caret (^) is the default.
|
I've left few rather concrete comments (on the few files I could have a look). Question: Shall we still push changes to this branch, or wait until everything is reviewed? |
commit 1c0522f Merge: 4c239d5 ee93bd4 Author: Benoît Richard <[email protected]> Date: Sun Jul 23 23:13:48 2023 +0200 Merge pull request #569 from vaerksted/master fix typos commit ee93bd4 Author: spaette <[email protected]> Date: Sat Jul 22 12:11:01 2023 -0500 typos commit 4c239d5 Author: Benoît Richard <[email protected]> Date: Tue Jul 4 00:35:20 2023 +0200 Bump version commit 249040d Merge: 4404658 7bef23e Author: Benoît Richard <[email protected]> Date: Tue Jul 4 00:34:13 2023 +0200 Merge pull request #525 from petvana/simplified-mod Simplified version of mod(x::Interval, y::Real) commit 4404658 Author: Benoît Richard <[email protected]> Date: Wed Jun 14 14:03:14 2023 +0200 Bump version for release commit 7bef23e Author: Petr Vana <[email protected]> Date: Fri May 27 11:11:53 2022 +0200 Cleanup commit f9f4733 Author: Petr Vana <[email protected]> Date: Fri May 27 11:10:05 2022 +0200 Throw ArgumentError for Interval divisor for mod commit 6fdc809 Merge: 439723f d2603d6 Author: Petr Vana <[email protected]> Date: Fri May 27 11:01:43 2022 +0200 Merge branch 'simplified-mod' of github.com:petvana/IntervalArithmetic.jl into simplified-mod commit 439723f Author: Petr Vana <[email protected]> Date: Fri May 27 11:01:27 2022 +0200 Disable divisor for mod to be an interval commit d2603d6 Author: Petr Vana <[email protected]> Date: Thu May 26 11:34:04 2022 +0200 Update docs commit 45abc46 Author: Petr Vana <[email protected]> Date: Thu May 26 11:30:14 2022 +0200 Implementation for strictly negative divisors for mod commit ff47910 Author: Petr Vana <[email protected]> Date: Thu May 26 11:11:35 2022 +0200 Add todo for mod with between two intervals commit ea00b23 Author: Petr Vana <[email protected]> Date: Wed May 25 19:59:30 2022 +0200 Imrpove test coverage + use zero() commit b56f4be Author: Petr Vana <[email protected]> Date: Wed May 25 13:44:24 2022 +0200 Use ⊇ operator commit d23df89 Author: Petr Vana <[email protected]> Date: Tue May 24 21:13:53 2022 +0200 Update src/intervals/functions.jl Co-authored-by: lucaferranti <[email protected]> commit 153d749 Author: Petr Vana <[email protected]> Date: Tue May 24 20:27:51 2022 +0200 Improve testing commit fea1b34 Author: Petr Vana <[email protected]> Date: Tue May 24 20:10:05 2022 +0200 Introduce simplified version of mod
|
As discussed with @OlivierHnt this is now good, so I'm merging. |
|
I then also went to close all related issues 🎉 That was a lot, thanks a lot to everyone who contributed :) |
As discussed, this would bring the work done in 1.0-dev into master.
I'd be happy if it could be reviewed, especially to make sure I did not drop any tests when merging.
Closes #85; closes #94; closes #127; closes #182; closes #209; closes #229; closes #255; closes #316; closes #317; closes #319; closes #345; closes #346; closes #410; closes #416; closes #434; closes #464; closes #470; closes #474; closes #491; closes #495; closes #513; closes #515; closes #538; closes #539.