WIP: vfmaddsub and friends for complex matmul #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have any questions/anything blocking you? |
|
Roughly in order of priority:
|
chriselrod
reviewed
Aug 1, 2022
| signs = Vec(ntuple(x -> ifelse(iseven(x), -one(T), one(T)), pick_vector_width(Float64))...) | ||
| if !η_bool & !θ_bool | ||
| cmatmul_ab(C, A, B) | ||
|
|
There was a problem hiding this comment.
Suggested change
| end |
maybe?
I just glanced at the code to see if there was any obvious cause to the error.
There was a problem hiding this comment.
Yeah this is all still very WIP. I'll work on this again tomorrow (hard maybe), just wanted to get this pushed since was switching around on machines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still incredibly WIP, and it's in the context of #140. I'm not really sure on how to proceed here, so dumping this here in case @chriselrod can see a way forward.