-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Julia 0.7 #92
Conversation
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
==========================================
+ Coverage 91.11% 99.19% +8.08%
==========================================
Files 3 3
Lines 270 248 -22
==========================================
Hits 246 246
+ Misses 24 2 -22
Continue to review full report at Codecov.
|
I think this will require a minor version bump, although it's possible that Julia 0.7 is exempted. |
I think dropping support is not a breaking change and it's okay with updating the patch version. |
If we update the minor version bump (with major version 0), I'd like to drop the deprecated methods such as |
That might be true. I know that bumping the Julia version typically requires a minor version bump, but perhaps that's only for packages that are at 1.0+. I can't remember seeing that documented though (it just fails when you try to register). |
Okay, I'll update the minor version and remove the deprecated methods in this PR. |
The logic, I think, is that bumping only the patch version means there are no intermediate versions you can use to later release bugfix supporting older Julia. I think there is no chance of doing that, and so would vote for On the other hand, now I see how many deprecated methods there are. Cleaning those up is nice. Are there other things waiting which might want to be in the same breaking release? |
I think #83 will also be considered breaking. EDIT: The PR was merged just now |
#83 is breaking anyway and just got bumped and merged, so I say we just go for it. Should we enforce a 1.6 minimum or are we content to keep supporting 1.0? |
May as well do 1.6, I think. Even if nothing needs it yet, it'll save bumping again when someone thinks of a feature that wants it. |
Okay, I'll drop the support for Julia 1.0 👍 |
We might also consider calling this 1.0? |
Maybe #75 deserves another look, too? |
Oh yeah. I vote we just rip those methods out, they seem really busted. |
Not fresh in my mind, but maybe #40 ( |
We can merge this and then separately decide whether to call the next release 0.6 or 1.0. |
Thanks @hyrodium ! |
I think we can drop support for Julia 0.7.