Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support riscv64 #1355

Merged
merged 5 commits into from
Dec 23, 2024
Merged

Support riscv64 #1355

merged 5 commits into from
Dec 23, 2024

Conversation

eschnett
Copy link
Contributor

No description provided.

@eschnett
Copy link
Contributor Author

This depends on JuliaIO/ObjectFile.jl#47 and JuliaPackaging/BinaryBuilderBase.jl#375. Tests will fail until these are merged.

@eschnett
Copy link
Contributor Author

The "full shard test" fails because CompilerSupportLibraries_jll is not yet available for riscv64. What is the solution? Build and deploy that package manually? Any others?

@giordano
Copy link
Member

Yes, we'll need to rebuild CSL as one of the first things, but we'll need to merge this PR first and update packages in Yggdrasil. If there isn't anything else outstanding here (I don't think?) we can do it.

@eschnett
Copy link
Contributor Author

That's the only failing test I see.

@eschnett
Copy link
Contributor Author

There is also the test "gfortran linking specialty flags". It tests a list of architectures (most of them?), but it doesn't test riscv64 yet.

@giordano giordano merged commit 31cdda0 into JuliaPackaging:master Dec 23, 2024
6 of 9 checks passed
@giordano giordano mentioned this pull request Dec 23, 2024
@giordano
Copy link
Member

Ugh, we should have updated

if any(p -> arch(p) == "armv6l" || (Sys.isbsd(p) && arch(p) == "aarch64"), platforms) && minimum_compat(julia_compat) < v"1.6"
to include the new platform

@giordano
Copy link
Member

The "full shard test" fails because CompilerSupportLibraries_jll is not yet available for riscv64. What is the solution? Build and deploy that package manually? Any others?

I guess I should have actually read the error message:

Linux riscv64 {cxxstring_abi=cxx03, libc=glibc, libgfortran_version=5.0.0}: Error During Test at /data/staticfloat/bb_azp/rootfs/agent_2/_work/1/s/test/building.jl:105
  Got exception outside of a @test
  MethodError: Cannot `convert` an object of type Nothing to an object of type CompilerShard
  Closest candidates are:
    convert(::Type{T}, ::T) where T at /data/staticfloat/bb_azp/rootfs/usr/local/julia-1.7/share/julia/base/essentials.jl:218
    CompilerShard(::Any, ::Any, ::Any, ::Any; target) at /data/staticfloat/bb_azp/rootfs/agent_2/depot/packages/BinaryBuilderBase/klKgJ/src/Rootfs.jl:26

This couldn't have been related to CSL, since that's not a CompilerShard, but just a package which may or may not be requested at runtime. Instead, the problem was that the Rust toolchain was requested but not found. Fixed in #1357.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants