Fix type instabilities in the init_header #70
Merged
+12
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… being poorly inferred and eager_mode not constant folding to being set.
topolarity
approved these changes
Oct 10, 2024
topolarity
reviewed
Oct 10, 2024
| push!(eager_mode, :(isdefined($(dep), :eager_mode) && $(dep).eager_mode())) | ||
| depmod = getglobal(__module__, dep) | ||
| if isdefined(depmod, :eager_mode) | ||
| push!(eager_mode, :($(dep).eager_mode())) |
There was a problem hiding this comment.
Suggested change
| push!(eager_mode, :($(dep).eager_mode())) | |
| push!(eager_mode, :($(dep).eager_mode()::Nothing)) |
Not really necessary since it's unused, but arguably good for hygiene
…ach to PATH_list and LIBPATH_list
topolarity
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_artifact_dir is porrly inferred due to us disabling inference. Also eager_mode isn't defined in stdlib jlls so make that a macro time check instead of a runtime one.