-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Geant4] Bump to latest version #10218
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
588ad6b
Bump version
peremato b025bcb
Patch for Windows not needed for this version
peremato 51a6f82
Patch for Windows not needed for this version
peremato 750cf95
Revert "Patch for Windows not needed for this version"
peremato c51204c
Patch for Windows still needed
peremato e7a63e4
Revert "Patch for Windows not needed for this version"
peremato 294d770
Patch for Windows still needed
peremato ec1ed92
Use system ZLIB for MacOS
peremato e223e6d
libG4zlib is optional, updated Expat
peremato e67c4f3
Seems expat is not available for riscv64
peremato File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,140 +1,75 @@ | ||
diff --git a/source/externals/ptl/src/Threading.cc b/source/externals/ptl/src/Threading.cc | ||
index 324d6c12d7..a7553d8db2 100644 | ||
--- a/source/externals/ptl/src/Threading.cc | ||
+++ b/source/externals/ptl/src/Threading.cc | ||
@@ -27,7 +27,7 @@ | ||
#include "PTL/Utility.hh" | ||
|
||
#if defined(PTL_WINDOWS) | ||
-# include <Windows.h> | ||
+# include <windows.h> | ||
#endif | ||
|
||
#if defined(PTL_MACOS) | ||
diff --git a/source/global/management/src/G4FindDataDir.cc b/source/global/management/src/G4FindDataDir.cc | ||
index 8c80180f71..7c5a6e0158 100644 | ||
--- a/source/global/management/src/G4FindDataDir.cc | ||
+++ b/source/global/management/src/G4FindDataDir.cc | ||
@@ -34,7 +34,7 @@ | ||
#include <cstdlib> | ||
#include <cstring> | ||
|
||
-#if defined(_MSC_VER) | ||
+#if defined(_WIN32) | ||
#define setenv(name, value, overwrite) _putenv_s(name, value) | ||
#endif | ||
|
||
diff --git a/source/global/management/src/G4Threading.cc b/source/global/management/src/G4Threading.cc | ||
index 3c6bd77b14..d793a7abff 100644 | ||
--- a/source/global/management/src/G4Threading.cc | ||
+++ b/source/global/management/src/G4Threading.cc | ||
@@ -34,8 +34,8 @@ | ||
#include "G4AutoLock.hh" | ||
#include "globals.hh" | ||
|
||
-#if defined(WIN32) || defined(__MINGW32__) | ||
-# include <Windows.h> | ||
+#if defined(_WIN32) | ||
+# include <windows.h> | ||
diff --git a/source/global/management/include/G4SliceTimer.hh b/source/global/management/include/G4SliceTimer.hh | ||
index fca9b3eb369..04c2d739267 100644 | ||
--- a/source/global/management/include/G4SliceTimer.hh | ||
+++ b/source/global/management/include/G4SliceTimer.hh | ||
@@ -39,7 +39,7 @@ | ||
#ifndef G4SLICE_TIMER_HH | ||
#define G4SLICE_TIMER_HH 1 | ||
|
||
-#if !(defined(WIN32) || defined(__MINGW32__)) | ||
+#if !defined(_WIN32) | ||
# include <sys/times.h> | ||
# include <unistd.h> | ||
#else | ||
# include <sys/syscall.h> | ||
# include <sys/types.h> | ||
diff --git a/source/processes/electromagnetic/dna/utils/include/G4MoleculeGun.hh b/source/processes/electromagnetic/dna/utils/include/G4MoleculeGun.hh | ||
index ef764260ac..54f9a8a17f 100644 | ||
--- a/source/processes/electromagnetic/dna/utils/include/G4MoleculeGun.hh | ||
+++ b/source/processes/electromagnetic/dna/utils/include/G4MoleculeGun.hh | ||
@@ -110,6 +110,8 @@ protected: | ||
void ShootAtFixedPosition(G4MoleculeGun*){} | ||
}; | ||
|
||
+template<> void TG4MoleculeShoot<G4Track>::Shoot(G4MoleculeGun* gun); | ||
+ | ||
template<typename TYPE> | ||
G4shared_ptr<G4MoleculeShoot> G4MoleculeShoot::ChangeType() | ||
@@ -49,7 +49,7 @@ | ||
extern "C" | ||
{ | ||
diff --git a/source/processes/hadronic/models/lend/include/MCGIDI.h b/source/processes/hadronic/models/lend/include/MCGIDI.h | ||
index e11303d2f4..3e4fa17887 100644 | ||
--- a/source/processes/hadronic/models/lend/include/MCGIDI.h | ||
+++ b/source/processes/hadronic/models/lend/include/MCGIDI.h | ||
@@ -9,7 +9,7 @@ | ||
#define MCGIDI_VERSION_MINOR 0 | ||
#define MCGIDI_VERSION_PATCHLEVEL 0 | ||
|
||
-#ifdef WIN32 | ||
+#ifdef _WIN32 | ||
#define M_PI 3.141592653589793238463 | ||
#endif | ||
|
||
diff --git a/source/processes/hadronic/models/lend/include/nf_specialFunctions.h b/source/processes/hadronic/models/lend/include/nf_specialFunctions.h | ||
index 4321f47a59..4868a156da 100644 | ||
--- a/source/processes/hadronic/models/lend/include/nf_specialFunctions.h | ||
+++ b/source/processes/hadronic/models/lend/include/nf_specialFunctions.h | ||
@@ -6,15 +6,12 @@ | ||
#ifndef specialFunctions_h_included | ||
#define specialFunctions_h_included | ||
|
||
+#define _USE_MATH_DEFINES | ||
#include <math.h> | ||
#include <float.h> | ||
int sysconf(int); | ||
-}; | ||
+} | ||
|
||
// Structure returned by times() | ||
// | ||
@@ -64,7 +64,7 @@ struct tms | ||
extern "C" | ||
{ | ||
extern clock_t times(struct tms*); | ||
-}; | ||
+} | ||
#endif /* WIN32 */ | ||
|
||
#include "G4Types.hh" | ||
diff --git a/source/global/management/include/G4Timer.hh b/source/global/management/include/G4Timer.hh | ||
index 022e3557df8..b0d8a358956 100644 | ||
--- a/source/global/management/include/G4Timer.hh | ||
+++ b/source/global/management/include/G4Timer.hh | ||
@@ -72,7 +72,7 @@ | ||
#ifndef G4TIMER_HH | ||
#define G4TIMER_HH 1 | ||
|
||
-#if !(defined(WIN32) || defined(__MINGW32__)) | ||
+#if !defined(_WIN32) | ||
# include <sys/times.h> | ||
# include <unistd.h> | ||
#else | ||
@@ -82,7 +82,7 @@ | ||
extern "C" | ||
{ | ||
int sysconf(int); | ||
-}; | ||
+} | ||
|
||
#include "nf_utilities.h" | ||
// Structure returned by times() | ||
|
||
-#ifdef WIN32 | ||
-#define M_PI 3.141592653589793238463 | ||
-#endif | ||
- | ||
#if defined __cplusplus | ||
extern "C" { | ||
namespace GIDI { | ||
diff --git a/source/processes/hadronic/models/lend/src/MCGIDI_energy.cc b/source/processes/hadronic/models/lend/src/MCGIDI_energy.cc | ||
index 65644c9727..d94d42eb78 100644 | ||
--- a/source/processes/hadronic/models/lend/src/MCGIDI_energy.cc | ||
+++ b/source/processes/hadronic/models/lend/src/MCGIDI_energy.cc | ||
@@ -5,7 +5,7 @@ | ||
#include <string.h> | ||
#include <cmath> | ||
@@ -97,7 +97,7 @@ struct tms | ||
extern "C" | ||
{ | ||
extern clock_t times(struct tms*); | ||
-}; | ||
+} | ||
#endif /* WIN32 */ | ||
|
||
#include "G4Types.hh" | ||
diff --git a/source/global/management/src/G4Timer.cc b/source/global/management/src/G4Timer.cc | ||
index 461d0141a0a..d45631602e6 100644 | ||
--- a/source/global/management/src/G4Timer.cc | ||
+++ b/source/global/management/src/G4Timer.cc | ||
@@ -41,7 +41,7 @@ | ||
# endif | ||
#endif | ||
|
||
-#ifdef WIN32 | ||
+#ifdef _WIN32 | ||
#define M_PI 3.141592653589793238463 | ||
#endif | ||
|
||
diff --git a/source/processes/hadronic/models/lend/src/MCGIDI_outputChannel.cc b/source/processes/hadronic/models/lend/src/MCGIDI_outputChannel.cc | ||
index d22caeb84d..86a3fbccef 100644 | ||
--- a/source/processes/hadronic/models/lend/src/MCGIDI_outputChannel.cc | ||
+++ b/source/processes/hadronic/models/lend/src/MCGIDI_outputChannel.cc | ||
@@ -2,6 +2,7 @@ | ||
# <<BEGIN-copyright>> | ||
# <<END-copyright>> | ||
*/ | ||
+#define _USE_MATH_DEFINES | ||
#include <string.h> | ||
#include <cmath> | ||
|
||
diff --git a/source/processes/hadronic/models/lend/src/nf_angularMomentumCoupling.cc b/source/processes/hadronic/models/lend/src/nf_angularMomentumCoupling.cc | ||
index ce8946de18..bc59181626 100644 | ||
--- a/source/processes/hadronic/models/lend/src/nf_angularMomentumCoupling.cc | ||
+++ b/source/processes/hadronic/models/lend/src/nf_angularMomentumCoupling.cc | ||
@@ -54,6 +54,7 @@ | ||
*/ | ||
|
||
#include <stdlib.h> | ||
+#define _USE_MATH_DEFINES | ||
#include <cmath> | ||
|
||
#include "nf_specialFunctions.h" | ||
diff --git a/source/processes/hadronic/models/lend/src/xDataTOM_importXML.cc b/source/processes/hadronic/models/lend/src/xDataTOM_importXML.cc | ||
index afa8a06987..07245f1a2c 100644 | ||
--- a/source/processes/hadronic/models/lend/src/xDataTOM_importXML.cc | ||
+++ b/source/processes/hadronic/models/lend/src/xDataTOM_importXML.cc | ||
@@ -11,8 +11,8 @@ | ||
#include <fcntl.h> | ||
#include <errno.h> | ||
# include <sys/types.h> | ||
# include <windows.h> | ||
|
||
-#if defined(WIN32) || defined(__MINGW32__) | ||
-#include <BaseTsd.h> | ||
+#if defined(_WIN32) | ||
+#include <basetsd.h> | ||
#include <io.h> | ||
#include <windows.h> | ||
#define realpath( a, b ) GetFullPathName( a, PATH_MAX, b, NULL ) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds like this patch should be upstreamed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes of course.