Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 1 to VTKPrimitives connectivity indices to follow convention in ReadVTK.jl #47

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Add 1 to VTKPrimitives connectivity indices to follow convention in ReadVTK.jl #47

merged 1 commit into from
Nov 9, 2023

Conversation

eliascarv
Copy link
Contributor

This convention is already working in the ".vtu" format and needs to be corrected in the ".vtp" format

@eliascarv eliascarv changed the title Add 1 to VTKPrimitives connectivity indices to follow convention in ReadVTK.jl Add 1 to VTKPrimitives connectivity indices to follow convention in ReadVTK.jl Nov 8, 2023
sloede
sloede reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I have just one minor question.

@ranocha I think this will require a minor version bump since the observable behavior changes, what do you think?

src/ReadVTK.jl Show resolved Hide resolved
sloede
sloede approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sloede sloede requested a review from ranocha November 8, 2023 20:13
ranocha
ranocha approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sloede Feel free to go ahead as you proposed 👍

@sloede sloede merged commit 8386a58 into JuliaVTK:main Nov 9, 2023
10 checks passed
@sloede
Copy link
Member

sloede commented Nov 9, 2023

ReadVTK.jl v0.2.0 was just released, which includes this PR.

@eliascarv eliascarv deleted the connectivity branch November 9, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranocha ranocha ranocha approved these changes

@sloede sloede sloede approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eliascarv @sloede @ranocha