Add dry-run validation to Loft and Shell #4711
Assignees
Comments
pierremtb
changed the title
pierremtb
changed the title
pierremtb
changed the title
guptaarnav
pushed a commit
that referenced
this issue
Jan 7, 2025
* WIP: mess with shell selection validation Will eventually fix #4711 * Update from main * WIP: not working yet * Working loft dry run validator * Clean up shell (still not working) * Bump kittycad-modeling-cmds * Clean up * Add logging * Add proper object_id and face_id mapping, still not working for shell * Fix faceId * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores) * Trigger CI * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores) * Add dry-run validation to Loft Checks one box for #4711 * Add extra check for non solid2ds --------- Co-authored-by: Adam Chalmers <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
guptaarnav
added a commit
that referenced
this issue
Jan 7, 2025
* implementing naive array pop * multi-profile follow up. (#4802) * multi-profile work * fix enter sketch on cap * fix coderef problem for walls and caps * allow sketch mode entry from circle * clean up * update snapshot * Look at this (photo)Graph *in the voice of Nickelback* * trigger CI * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * add test * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * fix how expression index is corrected, to make compatible with offset planes * another test * tweak test * more test tweaks * break up test to fix it hopfully * fix onboarding test * remove bad comment --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * get ready to bump (kcl-lib and friends) world (#4794) get ready to bump world Signed-off-by: Jess Frazelle <[email protected]> * Revert multi-profile (#4812) * Revert "multi-profile follow up. (#4802)" This reverts commit 2b2ed47. * Revert "multi profile (#4532)" This reverts commit 04e586d. * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * Re-run CI after snapshots * Re-run CI after snapshots * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores) * Re-run CI after snapshots * Add `fixme` to onboarding test --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add tracking of operations for the feature tree (#4746) * Add operations tracking for the timeline * Change to only track certain stdlib functions as operations * Update gen files * Add operations to simulation snapshot tests * Add tracking of positional function calls * Fix generated field names to be camel case in TS * Fix generated TS field names to match and better docs * Fix order of ops with patternTransform * Fix sweep to be included * Add new expected test outputs * Add tracking for startSketchOn * Update ops output to include startSketchOn * Fix serde field name * Fix output field name * Add tracking of operations that fail * Add snapshots of operations even when there's a KCL execution error * Add ops output for error executions * Add operations output to executor error * Update op source ranges * Remove tracking of circle() and polygon() since they're not needed * Update output without circle and polygon * Fix to track patternCircular3d and patternLinear3d * Remove tracking for mirror2d * Update ops output * Fix to track the correct source range of function definitions --------- Co-authored-by: Frank Noirot <[email protected]> * Change KCL completion to use new object/record syntax (#4815) * Reserve syntax for units of measure (#4783) * Allow underscores but only for un-referenced names Signed-off-by: Nick Cameron <[email protected]> * Support numeric suffixes for UoM types Signed-off-by: Nick Cameron <[email protected]> * UoM type arguments Signed-off-by: Nick Cameron <[email protected]> * warnings -> non-fatal errors Signed-off-by: Nick Cameron <[email protected]> * type ascription Signed-off-by: Nick Cameron <[email protected]> --------- Signed-off-by: Nick Cameron <[email protected]> * Whole module imports (#4767) Signed-off-by: Nick Cameron <[email protected]> * Support completions from import statements (#4768) Signed-off-by: Nick Cameron <[email protected]> * Implements boolean logical and/or in kcl (#4678) * redoing bool logic impl on latest main * adding snapshot tests (removing .new) * removing accidental change smh:( * accepting client side scene snapshot * accepting png snapshot and triggering ci * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * accepting png again? * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores) * accepting grid visibility snapshot * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores) * accepting png snapshot * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores) * accepting png snapshot * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * accepting png snapshot * rerunning simtest creation to get ops.snap files --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jonathan Tran <[email protected]> * Annotations syntax and per-file default units preparatory work (#4822) * Parse annotations Signed-off-by: Nick Cameron <[email protected]> * Propagate settings from annotations to exec_state Signed-off-by: Nick Cameron <[email protected]> --------- Signed-off-by: Nick Cameron <[email protected]> * KCL: Unlabeled first param defaults to % (#4817) Part of #4600 KCL functions can declare one special argument that doesn't require a label on its parameter when called. This PR will default that arg to % (the current pipeline) if not given. * Deprecate startSketchAt() stdlib function (#4819) * Deprecate startSketchAt() stdlib function * Remove uses of startSketchAt() from the doc tests * Update docs * Add dry-run validation for Loft (#4820) * WIP: mess with shell selection validation Will eventually fix #4711 * Update from main * WIP: not working yet * Working loft dry run validator * Clean up shell (still not working) * Bump kittycad-modeling-cmds * Clean up * Add logging * Add proper object_id and face_id mapping, still not working for shell * Fix faceId * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores) * Trigger CI * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores) * Add dry-run validation to Loft Checks one box for #4711 * Add extra check for non solid2ds --------- Co-authored-by: Adam Chalmers <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Double click label on sketch to dimension (#4816) * feat: double click segment label to dimension length, POC, need to clean up code! * fix: cleaning up the PR for review * fix: cleaning for the PR. Adding more comments and moving some logic * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * fix: mergining main, auto linter and tsc fixes. Need to make some more * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * fix: tsc errors are resolved * chore: added test for constraint * fix: fixing overlay bug since length labels can now be clicked. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * KCL: Show beautiful Miette errors when a KCL example test fails (#4829) * KCL: Show beautiful Miette errors when a KCL example test fails Background: KCL example tests are generated from the stdlib KCL examples in the `#[stdlib]` macro in derive-docs. Problem: When these tests fail, they output a really unhelpful error message like Kcl(Semantic(KclErrorDetails { source_ranges: [156, 160, 0], message: "Expected a sketch but found array" } )). Solution: Use miette. Now the errors highlight the KCL code that failed and show exactly what went wrong, on which line, presenting nice diagnostics that look like cargo/rustc output. * Update helix snapshots * Move all tests over to electron (#4484) * Move all tests over to electron * Pass the correct param to playwright-electron.sh * Add shebang to script and add macos-14-large as a target * Get sketch-tests.spec.ts passing in electron * Try out 4 workers * Got testing-segment-overlays passing * Pass testing-selections.spec.ts * Go back to fix up sketch-tests test * Pass various.spec.ts, by far the hardest one * Pass can-sketch-on-all-planes... with ease * Pass command bar tests * fmt * Completely fix code mirror text navigating for tests * Pass debug pane tests * Pass desktop export tests * Pass editor tests * Pass file tree tests * Pass onboarding tests * Corrected a fixme in file-tree.spec! * Painfully fix hardcoded coordinates in point-click.spec * Pass machine.spec tests * Pass projects, fought hard with filechooser * Pass regresion-tests.spec tests * Pass network and connection tests * Pass camera-movement.spec tests * Extreme time eaten by gizmo test fixes. All passing now. * Merge main (tests changed x_x) and pass all constraints.spec tests (pain) * Pass another painful spec suite: testing-settings * Pass perspective-toggle, interesting note * Pass samples loading tests * Pass app header tests * Pass text-to-cad tests * Pass segment-overlays (minor ache) and ability to switch to web if needed :) * Fix a ton of syntax changes and deflake 2 more tests (pain) * Correct all tsc errors * Remove to-electron script * Add an f-ton of shit because playwright doesnt want S P R E A D * Try CI again * Stop snapshots of exports (already test in e2e) * Fix flake in double click editor * Hopefully help CI flake * Fixmes, fixmes everywhere * One more fixme to settings * Skip another code pane flake * Port jess's projects.spec tests * fixup * Reuse electron window; difficult task * Rebased and refixed * Remove duplicate cases * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * Reduce the workers to something CI can handle * Lower it further, we need to think about the others * Update package.json Co-authored-by: Pierre Jacquier <[email protected]> * Update package.json Co-authored-by: Pierre Jacquier <[email protected]> * Fix the last tests and tsc errors * Timeout to 120 and windows-2022-16core * Fix windows runner detection, enable concurrency temporarily * Hopefully this time fix windows runner detection * Comment out Vector, add back removed camera test code * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: macos-14-large) * A snapshot a day keeps the bugs away! 📷🐛 (OS: macos-14-large) * Fix camera tests again * Massively deflake a whole class of tests * A snapshot a day keeps the bugs away! 📷🐛 (OS: macos-14-large) * A snapshot a day keeps the bugs away! 📷🐛 (OS: macos-14-large) * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * Try new CI and fix small onboarding test * Derp * No github tuning * Try mac * Add back all the OS * Lord, hallow be thy name * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores) * One last try with window-16-cores * Trigger CI * Try AWS Windows runner * Passing on windows locally with a few skips * Skip more win tests, add back all three oses * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-16-cores) * Add two more fixmes * 2 more fixmes * skip segment overlays on win32 * Another fixme * Trigger CI * Trigger CI * Quick clean up * Move all tests over to electron * Pass the correct param to playwright-electron.sh * Add shebang to script and add macos-14-large as a target * Get sketch-tests.spec.ts passing in electron * Try out 4 workers * Got testing-segment-overlays passing * Pass testing-selections.spec.ts * Go back to fix up sketch-tests test * Pass various.spec.ts, by far the hardest one * Pass can-sketch-on-all-planes... with ease * Pass command bar tests * fmt * Completely fix code mirror text navigating for tests * Pass debug pane tests * Pass desktop export tests * Pass editor tests * Pass file tree tests * Pass onboarding tests * Corrected a fixme in file-tree.spec! * Painfully fix hardcoded coordinates in point-click.spec * Pass machine.spec tests * Pass projects, fought hard with filechooser * Pass regresion-tests.spec tests * Pass network and connection tests * Pass camera-movement.spec tests * Extreme time eaten by gizmo test fixes. All passing now. * Merge main (tests changed x_x) and pass all constraints.spec tests (pain) * Pass another painful spec suite: testing-settings * Pass perspective-toggle, interesting note * Pass samples loading tests * Pass app header tests * Pass text-to-cad tests * Pass segment-overlays (minor ache) and ability to switch to web if needed :) * Fix a ton of syntax changes and deflake 2 more tests (pain) * Correct all tsc errors * Remove to-electron script * Add an f-ton of shit because playwright doesnt want S P R E A D * Try CI again * Stop snapshots of exports (already test in e2e) * Fix flake in double click editor * Hopefully help CI flake * Fixmes, fixmes everywhere * One more fixme to settings * Skip another code pane flake * Port jess's projects.spec tests * fixup * Reuse electron window; difficult task * Rebased and refixed * Remove duplicate cases * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * Reduce the workers to something CI can handle * Lower it further, we need to think about the others * Update package.json Co-authored-by: Pierre Jacquier <[email protected]> * Update package.json Co-authored-by: Pierre Jacquier <[email protected]> * Fix the last tests and tsc errors * Timeout to 120 and windows-2022-16core * Fix windows runner detection, enable concurrency temporarily * Hopefully this time fix windows runner detection * Comment out Vector, add back removed camera test code * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: macos-14-large) * A snapshot a day keeps the bugs away! 📷🐛 (OS: macos-14-large) * Fix camera tests again * Massively deflake a whole class of tests * A snapshot a day keeps the bugs away! 📷🐛 (OS: macos-14-large) * A snapshot a day keeps the bugs away! 📷🐛 (OS: macos-14-large) * Try new CI and fix small onboarding test * Derp * No github tuning * Try mac * Add back all the OS * Lord, hallow be thy name * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores) * Try AWS Windows runner * Passing on windows locally with a few skips * Trigger CI * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) * fmt, tsc, lint * Enable two fixmes again * Fix lint, codespell, fmt * Fix lint * Don't run e2e on draft, add back concurrency, clean up * One last windows skip --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Pierre Jacquier <[email protected]> Co-authored-by: Pierre Jacquier <[email protected]> * Add blank line to discord bot message (#4814) * Add blank link to discord bot message * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores) * Trigger CI * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores) * Trigger CI * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-16-cores) * Trigger CI --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Implement some basic cache program generation (#4840) Implement some basic cache program generation A bit ago, @jessfraz added the ability to control reexecution from the executor. When we did this, it used the digest to determine if there was a code change rather than a non-code change (whitespace, comment, etc). This allows the creation of a new program to be run without clearing the scene. This, in conjunction with being able to delete Engine objects by ID will allow us to do some clever stuff when incrementally executing a program. I'm still working on something a bit more advanced, but a good first step to derisk some of the caching behavior here fully is to implement a basic "changed program" stub. This process the ast programs (old and new) if it doesn't exactly match. This would have been a complete refresh before this commit. 1) Check all overlapping top-level statements of the body of the new and old AST and ensure they all match. - If this is true, this means that one of the two AST programs has more elements then the other, and they all otherwise match (addition or deletion of the end of the program). We continue to #2 in this case. - If this is false, we have a meaingful difference in a section of overlapping code. This will result in a cache miss and rebuild the scene. We short-cut here and the scene is rebuilt. 2) Check the lengths of the two bodies. - If they're the same, we shouldn't have even been called. We will short-cut with a noop cache return (no clear, no program). - if the old ast is longer, we've removed instructions from the program. We can't delete things now, so this will result in a cache miss and rebuild the scene. We short-cut here and the scene is rebuilt. - If the new ast is longer, we have an insertion of code at the end. 3) construct a new program using only the new elements from the new ast, and return a `CacheResult` that *does not clear the scene*. This means nothing will be rebuilt, and only a new object will polp onto the scene. This is the first case where we diverge with existing behavior. Signed-off-by: Paul R. Tagliamonte <[email protected]> * Fix mac issue after electron test migration PR (#4842) Fix mac issue after electron test migration pR * Remove guards from modeling commands in the toolbar (#4800) * Remove guards from modeling commands in the toolbar * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores) * Remove the deprecated function, update doc comment for the one still in use * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores) * Remove more selection check functions that are no longer used * Update E2E tests that assumed the extrude button could be disabled due to selection * Update a few fillet tests that expected the button to disable based on selection * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-16-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-macos-8-cores) * Trigger CI * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-16-cores) * Trigger CI --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Pierre Jacquier <[email protected]> * Prompt to edit (#4830) * initial plumbing for getting the new option into the cmd-bar * start of prompt edit * update AI poll * add spinner * more prompt engineering * add success toast, allowing user's to reject code * select code that changed in prompt to edit * selection in scene should not disappear when opening prompt cmd * tweak * fmt * add tests * some clean up * clean up * fix tests * Yeet telemetry to text to cad endpoint (#4847) yeet telemetry to text to cad endpoint * Tweak prompt wording (#4846) tweak prompt wording * update discord bot (#4837) * Re-enable test 'code pane closed at start' after electron migration (#4841) * Re-enable 'code pane closed at start' Relates to #4838 * Enable test on current branch * Revert "Enable test on current branch" This reverts commit 0d970b9. * Add 3-point circle tool (#4832) * Add 3-point circle tool This adds a 1st pass for the 3-point circle tool. There is disabled code to drag around the 3 points and redraw the circle and a triangle created by those points. It will be enabled in a follow-up PR when we have circle3Point in the stdlib. For now, all it does is after the 3rd click, will insert circle center-radius KCL code for users to modify. * PR comments * First draft of a feature tree pane (#4782) * Fix e2e default planes tests to use mask on state indicator (#4849) * Fix e2e default planes tests to use mask on state indicator * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-16-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-16-cores) * Trigger CI --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: don't error on failure to fetch privacy settings (#4799) * fix: dont error on failure to fetch privacy settings * Add console warning when we ignore it --------- Co-authored-by: Tom Pridham <[email protected]> * Match package license to LICENSE file (#4882) * Remove the old Loft GitHub issue link in the toolbar (#4848) Now that it's available, it shouldn't be there anymore. * Fix fuzz crate lints and update deps (#4873) * Fix fuzz to use new API * Fix fuzz Cargo.toml lints and update lock * Use app foreground color for focus outline button color so there's no hue collision (#4894) Towards #4851 * Add support for float numbers in rem() arguments (#4858) * Add support for float numbers in rem() arguments * Update docs * Rename to prevent name collision in docs * Update docs after rename to NumberArg * Fix parameter types to follow naming convention * Change doc comment description to not refer to floating point * Update docs after NumberArg doc change * Change function to be more condensed * Change to not try to preserve ints * Update docs to use f64 * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-macos-8-cores) * Trigger CI --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add auto-retries to macOS build notarization (#4892) * Add DEBUG=electron-notarize* to build-apps * Force IS_RELEASE: true * Temp: Disable version setting based on tag * Remove deprecated notarize.teamId and add retry logic * Revert "Remove deprecated notarize.teamId and add retry logic" This reverts commit 6ff98d7. * Retry only on macOS * Better retry logic for macOS * Use nick-fields/retry * Clean up Temp: commits for PR * Clean up * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-macos-8-cores) * Trigger CI --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Bump nanoid from 3.3.7 to 3.3.8 (#4731) Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.7 to 3.3.8. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.3.7...3.3.8) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Enable enter for autocompletions in the command palette KCL input (#4896) * Enable enter for autocompletions in the command palette KCL input * Oops I commented out code for the variable name input Thanks for the catch @pierremtb --------- Co-authored-by: Pierre Jacquier <[email protected]> * Bump rollup from 4.21.0 to 4.29.1 (#4888) * Bump rollup from 4.21.0 to 4.29.1 Bumps [rollup](https://github.com/rollup/rollup) from 4.21.0 to 4.29.1. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v4.21.0...v4.29.1) --- updated-dependencies: - dependency-name: rollup dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Pierre Jacquier <[email protected]> * Louder Windows codesign errors (#4762) * WIP: Silent failure in signWin.js Fixes #4582 * Temp: force release build * Fake throw * Temp: another test * Clean up for merge * Add parsing keyword function calls inside pipelines (#4907) Co-authored-by: Adam Chalmers <[email protected]> * Remove draft PR filter on e2e tests (#4908) * Add three point circle stdlib function (#4893) * Add parsing keyword function calls inside pipelines Co-authored-by: Adam Chalmers <[email protected]> * Add three point circle stdlib function * Generate new documentation * Fix 20:20 for the circle three point test * Convert to using keyword arguments * Wtf yo * Remove unused structure * Use the new simulation tests * Regenerate documentation --------- Co-authored-by: Jonathan Tran <[email protected]> Co-authored-by: Adam Chalmers <[email protected]> * Move the base CodeMirror KCL support to a local package (#4897) * Move CodeMirror LRLanguage to new file This separates the base language support from the LSP and color picker. * Move the base CodeMirror KCL support to a local package * Start CodeMirror grammar tests * Exclude vitest config in tsconfig * Add KCL path to tsconfig * Remove stray import * Drop extension from import * Use __filename for commonjs compat * Check exec return before access * Build ES and CJS to dist * Format * Exclude all.test.ts from codespell This is to work around "fileTests" imported from Lezer. Future codespell versions look like they'll allow the code to be annotated, which would be nicer. --------- Co-authored-by: Matt Mundell <[email protected]> * Fix typo in README (#3843) Co-authored-by: Jess Frazelle <[email protected]> * remove backwards compatibility for snake case in objects (#4920) Signed-off-by: Jess Frazelle <[email protected]> * CM KCL: Support `=` in record init (#4933) Support `=` in record init Co-authored-by: Matt Mundell <[email protected]> * Bump clap from 4.5.21 to 4.5.23 in /src/wasm-lib (#4928) Bumps [clap](https://github.com/clap-rs/clap) from 4.5.21 to 4.5.23. - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@clap_complete-v4.5.21...clap_complete-v4.5.23) --- updated-dependencies: - dependency-name: clap dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @kittycad/lib from 2.0.7 to 2.0.12 (#4922) Bumps [@kittycad/lib](https://github.com/KittyCAD/kittycad.ts) from 2.0.7 to 2.0.12. - [Release notes](https://github.com/KittyCAD/kittycad.ts/releases) - [Commits](KittyCAD/kittycad.ts@v2.0.7...v2.0.12) --- updated-dependencies: - dependency-name: "@kittycad/lib" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump anyhow from 1.0.94 to 1.0.95 in /src/wasm-lib (#4929) Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.94 to 1.0.95. - [Release notes](https://github.com/dtolnay/anyhow/releases) - [Commits](dtolnay/anyhow@1.0.94...1.0.95) --- updated-dependencies: - dependency-name: anyhow dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump url from 2.5.3 to 2.5.4 in /src/wasm-lib (#4930) Bumps [url](https://github.com/servo/rust-url) from 2.5.3 to 2.5.4. - [Release notes](https://github.com/servo/rust-url/releases) - [Commits](servo/rust-url@v2.5.3...v2.5.4) --- updated-dependencies: - dependency-name: url dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump wasm-streams from 0.4.1 to 0.4.2 in /src/wasm-lib (#4926) Bumps [wasm-streams](https://github.com/MattiasBuelens/wasm-streams) from 0.4.1 to 0.4.2. - [Release notes](https://github.com/MattiasBuelens/wasm-streams/releases) - [Changelog](https://github.com/MattiasBuelens/wasm-streams/blob/main/CHANGELOG.md) - [Commits](MattiasBuelens/wasm-streams@v0.4.1...v0.4.2) --- updated-dependencies: - dependency-name: wasm-streams dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @csstools/postcss-oklab-function from 4.0.2 to 4.0.7 (#4923) Bumps [@csstools/postcss-oklab-function](https://github.com/csstools/postcss-plugins/tree/HEAD/plugins/postcss-oklab-function) from 4.0.2 to 4.0.7. - [Changelog](https://github.com/csstools/postcss-plugins/blob/main/plugins/postcss-oklab-function/CHANGELOG.md) - [Commits](https://github.com/csstools/postcss-plugins/commits/HEAD/plugins/postcss-oklab-function) --- updated-dependencies: - dependency-name: "@csstools/postcss-oklab-function" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: writes to disk when the user accepts the prompt to edit (#4942) * fix: writes to disk when the user accepts the prompt to edit * fix: then catch * Make circle3Point tool an actor (#4906) * Reduce the amount of data sent to TS and make new fields opt-in (#4913) * Reduce the amount of data sent back to JS/TS from WASM * Remove unneeded derives since we shouldn't expose these types * Alias type to be clearer * Bump syn from 2.0.87 to 2.0.95 to be compatible with modeling-cmds 0.… (#4945) Bump syn from 2.0.87 to 2.0.95 to be compatible with modeling-cmds 0.2.86 * fix out of range error (#4931) * fix out of range error Signed-off-by: Jess Frazelle <[email protected]> * updates Signed-off-by: Jess Frazelle <[email protected]> * remove console logs Signed-off-by: Jess Frazelle <[email protected]> * add a regression test Signed-off-by: Jess Frazelle <[email protected]> --------- Signed-off-by: Jess Frazelle <[email protected]> * Run chrome e2e snapshots only on linux (#4947) * Run chrome e2e snapshots only on linux * Wtf is this 1-indexed * Force 1/1 sharding * Add TODO * Nadro/3079/screenshot improvements (#3917) * chore: swapped screenshot to only use the video stream * feat: video stream screenshot, native electron screenshot * fix: auto tsc, fmt, xgen, lint * fix: fixing tsc errors * fix: removing debug console.log * fix: renaming ScreenShot to Screenshot * fix: deleting console log from debugging * fix: bug with what source was referenced * fix: using a productName * fix: improving usage for native screenshots and detecthing support * fix: fmt * chore: updated rust test documentation * fix: typo in readme * fix: leaving package.json and yarn.lock the same as main?? * bump * bump * bump again * bump again2 * feat: implemented zoom to fit on code change if previous AST was empty (#3925) * feat: implemented zoom to fit on code change if previous AST was empty * feat: implementing selectAll text logic to enable select all and copy and paste and zoom to fit will work * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest) * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest) * fix: clarifying comment in _isAstEmpty * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest) * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest) * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest) * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * bump * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores) * bump again * fix: fixing new type since this branch is old * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores) * bump * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-16-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-16-cores) --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: 49fl <[email protected]> * Add dependabot group for all serde dependencies (#4944) * Fix formatting of dependabot.yml * Add dependabot group for all serde dependencies * CM KCL: = and => are optional in fn declarations (#4941) CM KCL: `=` and `=>` are optional in fn declarations Co-authored-by: Matt Mundell <[email protected]> * Bump ts-rs from 10.0.0 to 10.1.0 (#4949) * Add toolbar buttons for text-to-cad and prompt-to-edit (#4938) * Add toolbar buttons for text-to-cad and prompt-to-edit Resolves #4890 * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-16-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-16-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-16-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-macos-8-cores) * `preventDefault` on <kbd>Enter</kbd> with textarea input so buttons aren't clicked as well * A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-16-cores) * Trigger CI --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Pierre Jacquier <[email protected]> * Bump quote from 1.0.37 to 1.0.38 in /src/wasm-lib (#4951) Bumps [quote](https://github.com/dtolnay/quote) from 1.0.37 to 1.0.38. - [Release notes](https://github.com/dtolnay/quote/releases) - [Commits](dtolnay/quote@1.0.37...1.0.38) --- updated-dependencies: - dependency-name: quote dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * array pop with unlabled kw arg --------- Signed-off-by: Jess Frazelle <[email protected]> Signed-off-by: Nick Cameron <[email protected]> Signed-off-by: Paul R. Tagliamonte <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Kurt Hutten <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jess Frazelle <[email protected]> Co-authored-by: Frank Noirot <[email protected]> Co-authored-by: Jonathan Tran <[email protected]> Co-authored-by: Nick Cameron <[email protected]> Co-authored-by: Adam Chalmers <[email protected]> Co-authored-by: Pierre Jacquier <[email protected]> Co-authored-by: Kevin Nadro <[email protected]> Co-authored-by: 49fl <[email protected]> Co-authored-by: Pierre Jacquier <[email protected]> Co-authored-by: Paul Tagliamonte <[email protected]> Co-authored-by: Josh Gomez <[email protected]> Co-authored-by: Tom Pridham <[email protected]> Co-authored-by: Matt Mundell <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Matt Mundell <[email protected]> Co-authored-by: alteous <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Follow up from #4666, thread #4666 (comment)
The text was updated successfully, but these errors were encountered: