Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dry-run validation to Shell #4775

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Add dry-run validation to Shell #4775

wants to merge 20 commits into from
+113 −19

Conversation

pierremtb
Copy link
Collaborator

@pierremtb pierremtb commented Dec 12, 2024 •
edited
Loading

Fixes #4711

@qa-wolf QA Wolf
Copy link

qa-wolf bot commented Dec 12, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@vercel Vercel
Copy link

vercel bot commented Dec 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Jan 8, 2025 5:04pm

@pierremtb pierremtb requested a review from nadr0 December 12, 2024 21:29
@pierremtb pierremtb changed the title WIP: shell and loft dry run validation Add dry-run validation to Loft and Shell Dec 13, 2024
@pierremtb pierremtb mentioned this pull request Dec 16, 2024
Merged
@pierremtb pierremtb changed the title Add dry-run validation to Loft and Shell Add dry-run validation to Shell Dec 17, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.84%. Comparing base (76e7d80) to head (6a39314).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4775   +/-   ##
=======================================
  Coverage   85.84%   85.84%           
=======================================
  Files          86       86           
  Lines       30894    30894           
=======================================
  Hits        26522    26522           
  Misses       4372     4372
Flag Coverage Δ
wasm-lib 85.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierremtb pierremtb mentioned this pull request Jan 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadr0 nadr0 Awaiting requested review from nadr0

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dry-run validation to Loft and Shell
2 participants
@pierremtb @adamchalmers