Feature: new axis and edge selection workflow for point and click revolve #4939
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Do you know why this snapshot changed?
There was a problem hiding this comment.
I think our dev infra is struggling a bit, but maybe we shouldn't commit this one?
| @@ -337,8 +338,31 @@ export const modelingMachineCommandConfig: StateMachineCommandSetConfig< | |||
| required: true, | |||
| skip: true, | |||
| }, | |||
| axis: { | |||
| axisOrEdge: { | |||
There was a problem hiding this comment.
Was there no affordance like label to let you fix that AxisOrEdge thing you mentioned in your demo video? I can make an issue for that, we should make that not bound to the argument name in the source code.
There was a problem hiding this comment.
Discussed in Slack, we'll address this missing functionality of the command palette configuration in another PR.
| @@ -47,7 +47,9 @@ export type ModelingCommandSchema = { | |||
| Revolve: { | |||
| selection: Selections | |||
| angle: KclCommandValue | |||
| axis: Selections | |||
| axisOrEdge: string | |||
There was a problem hiding this comment.
[nit] this could be a union type of 'Axis' | 'Edge' I think
There was a problem hiding this comment.
i dont think these were supposed to generate
There was a problem hiding this comment.
maybe you need to rebase on pierres change to the snapshot tests
|
needs a playwright test :) |
nadr0
changed the title
Issue
Original revolve ticket #3714
This is an additional feature to improve the point and click workflow.
We want the ability to let the user to select edges or local sketch axis from the point and click workflow
Implementation
axis = <>result'X'and'Y'when they select local sketch axisFuture support
This should unblock the point and click workflow for revolve for users. I think once this is in nightly for a few days we can remove the dev only flag and release it to users. Since they can choose any
axis = <>value and we have dry runs to prevent bad edge selections.Demo video
2025-01-06.10-29-29.mp4