Add persisted setting for model auto-rotate behavior #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
sick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per user feedback, some people would like to have models not auto-rotate by default so that they can inspect an area more closely and leave it without losing their place.
My quick solution for this is to include a toggle in the "footer" of the model view page to toggle the auto-rotation behavior. This persists a "user settings" object in browser storage with just one boolean setting for the time being, which controls auto-rotate. This will allow us to extend user settings into a full menu in the near future as we get more configuration requests.
Demo
auto-rotate-toggle-demo-compressed.mp4