-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parseStringSync #422
base: master
Are you sure you want to change the base?
Add parseStringSync #422
Conversation
Create a sync version of parseString to API to permit calling without a callback. The current implemenation is sync due to underlying implementation of SAX parser. Examples: ```js // Via root API var result = xml2js.parseStringSync('< ... >', options) // Via parser var parser = new xml2js.Parser(options); var result = parser.parseStringSync('< ... >'); ``` See Leonidas-from-XIV#241 by @nobodyman See Leonidas-from-XIV#319 by @mrparkers
fa6a733
to
c7df57c
Compare
1 similar comment
It would be nice if it could be merged |
👍 to this, there should be no I/O happening in a function called |
+1 |
any ideas when this can be merged? |
Please merge this.. |
lol why would this not be merged? |
For a function that is called Nevertheless, I hope that volunteers will get permission to continue maintenance. |
@Leonidas-from-XIV Plz merge this... I need sync function because I'm trying converting the parser to "sync"
|
Create a sync version of parseString to API to permit calling without a callback. The current implementation is sync due to underlying implementation of SAX parser.
This is a rebased version of #319 by @mrparkers which in turn was an add-on to #241 by @nobodyman. In addition to those changes, this PR:
Examples:
See #241 by @nobodyman
See #319 by @mrparkers