-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch on ambiguities and piracies #80
base: master
Are you sure you want to change the base?
Switch on ambiguities and piracies #80
Conversation
tro3/ThreadPools.jl#36 must be resolved in order to fix the |
…stream) Defining this piracy just hides errors.
Which struct helpers do you mean? Things like toDict, toTOML and so on? Or the "MDF" queries like rxBandwidth and the rest? For toDict and toTOML, we also have a similar setup in AbstractImageReconstruction and the RecoPlans. However, for MPIMeasurements the resulting dicts and tomls are intended to be edited by humans at time and we have "custom" parsing/constructor logic for each struct. In AbstractImageReconstruction, this things are not intended to be human-editable and so it's mostly recursively walking through the structs. The latter case is mostly internal to AbstractImageReconstruction and at most should be extended in MPIReco. For toDict or rxBandwith and so on, we could make a package in the general registry but I would still make it MPI-specific |
I would focus on functions defined in https://github.com/MagneticParticleImaging/MPIMeasurements.jl/blob/master/src/Utils/StructToToml.jl and https://github.com/MagneticParticleImaging/MPIMeasurements.jl/blob/master/src/Utils/DictToStruct.jl. These functions are not really tied to the MPI packages and we could then use e.g. |
Random thought from outside: I think an MPI independent package for I needed both quite recently in MagneticFieldConfigurator: For Whether to couple TOML/HDF5 support in the package, I don't have a strong option. Just wanted express the usual use case. |
Closes #62