Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Difference plots and other stuff #1025

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Difference plots and other stuff #1025

wants to merge 20 commits into from

Conversation

jfrost-mo
Copy link
Member

@jfrost-mo jfrost-mo commented Jan 9, 2025 •
edited
Loading

This PR will be broken into multiple, then closed.

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

jfrost-mo added 20 commits January 9, 2025 14:24
@jfrost-mo
Generalise spatial plot log message
cce729e 
Not all spatial plots are contour plots nowdays.
@jfrost-mo
Add utility function for equalising attributes
d625e69 
Non-matching attributes are removed.
@jfrost-mo
Add utility function to get forecast initiation time
90f91eb 
Still WIP, as doesn't yet support UM.
@jfrost-mo
Add forecast reference time constraint
3a20962
@jfrost-mo
Add lead_time convertion and difference operators
5d94f1b
@jfrost-mo
Handle globbing anywhere in input path
eb7de15
@jfrost-mo
Extract forecast_reference_time from UM data
d8fec7f
@jfrost-mo
Format JSON when writing
c7570f8 
It isn't in any hot paths, and makes inspecting it much nicer.
@jfrost-mo
Improve fully_equalise_attributes
a174d96 
It now removes coordinates that are not present on all cubes.
@jfrost-mo
Add model name to cube metadata
8f31a43
@jfrost-mo
Make convert_to_leadtime model agnostic
4b5e0db
@jfrost-mo
Add attribute constraint operator
2d30f47
@jfrost-mo
Add forecast lead time constraint operator
aa5355c
@jfrost-mo
WIP Difference operator
fe839db 
Currently can't do UM-LFRic plots correctly, as the arrays are flipped.
@jfrost-mo
Handle sorting files outside the current directory
c0965d4
@jfrost-mo
Use bwr colorbar for difference plots
26761d1
@jfrost-mo
Limit domain statistics to 3 s.f. and move below plot
3fe1f44
@jfrost-mo
Reformat code
53c090e
@jfrost-mo
Reduce useless debug messages
083ff07
@jfrost-mo
Name differences per variable
0eb3e42 
This allows having a unique colour bar range for each difference type.
@jfrost-mo
Copy link
Member Author

Todo:

  • Add colorbar definitions for all variables.
  • Plumb through to workflow.
  • Fix errors.
  • Add tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jfrost-mo