Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user defined metadata - spatial #36

Merged
merged 9 commits into from
Jan 8, 2025
Merged

user defined metadata - spatial #36

merged 9 commits into from
Jan 8, 2025

Conversation

mo-marqh
Copy link
Member

Demonstration of user customised metadata from XIOS

This includes spatial coordinate reference system metadata definitions.

@mo-marqh mo-marqh requested a review from EdHone January 7, 2025 14:25
Copy link
Collaborator

@EdHone EdHone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked out the PR and run all the tests successfully, including the new test. I broke the new test a few times to test it's behaviour and everything seemed to behave properly.

I'm interested to see if similar behaviour can be achieved with the Fortran API as well - I might look into this in a future issue!

I believe the name of the python test test_resample_case.py should probably be renamed to something more appropriate. (Likewise with the class name/functions)

Technically I think the copywrite notice in the fortran program file should be changed to the year 2025, but I'm happy to overlook this as the code was probably written in 2024!

@mo-marqh
Copy link
Member Author

mo-marqh commented Jan 7, 2025

thanks @EdHone , there was some unhelpful naming here, which i have hopefully improved with the latest commit

@EdHone
Copy link
Collaborator

EdHone commented Jan 8, 2025

Thanks, Mark. I'm happy with the changes you've made and I've tested the PR again and everything is working just as well as before. Happy to squash and merge now

@EdHone EdHone merged commit cd13755 into MetOffice:main Jan 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants