Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Enhance ramps deeplink e2e #12821

Merged
merged 9 commits into from
Dec 21, 2024
Merged

test: Enhance ramps deeplink e2e #12821

merged 9 commits into from
Dec 21, 2024

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented Dec 20, 2024

Description

This PR updates some actions in the ramps deep-linking e2e tests to reflect changes from an earlier PR that fixed a few edge case bugs. It also sets up an Android-only CI workflow for the ramps tests.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 20, 2024
@cortisiko cortisiko self-assigned this Dec 20, 2024
Copy link
Contributor

github-actions bot commented Dec 20, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 19b8ee6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/35b46df4-53cc-4dde-aea2-7438f139585b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko marked this pull request as ready for review December 20, 2024 23:10
@cortisiko cortisiko requested review from a team as code owners December 20, 2024 23:10
@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 20, 2024
Copy link
Contributor

github-actions bot commented Dec 20, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1120ec2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b6b7b8e2-ceaa-4744-a470-cc50785470e3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko enabled auto-merge December 20, 2024 23:44
@cortisiko cortisiko added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 5fe6ace Dec 21, 2024
43 checks passed
@cortisiko cortisiko deleted the enhance-ramps-deeplink-e2e branch December 21, 2024 00:04
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2024
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants