-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add missing allowed action to the SmartTransactionsController
messenger
#12846
fix: Add missing allowed action to the SmartTransactionsController
messenger
#12846
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
ad50bb8
to
5c88b84
Compare
5c88b84
to
33d1348
Compare
Does this fix a bug? And does this address a problem in a recent PR? |
Quality Gate passedIssues Measures |
Yes this fixes a bug in smart transaction publish hook, falling back to regular transaction submission For reference MetaMask/metamask-extension#29473 |
Could you please create a GitHub issue for the bug on each platform? Or link it if it already exists. |
Add missing allowed action
NetworkController:getState
to theSmartTransactionsController
messenger.This fixes and error in smart transaction publish hook, falling back to regular transaction submission
Error: Action missing from allow list: NetworkController:getState
.Description
Related issues
Fixes: #12848
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist