Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing allowed action to the SmartTransactionsController messenger #12846

Merged

Conversation

cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Jan 7, 2025

Add missing allowed action NetworkController:getState to the SmartTransactionsController messenger.

This fixes and error in smart transaction publish hook, falling back to regular transaction submission
Error: Action missing from allow list: NetworkController:getState.

Description

Related issues

Fixes: #12848

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cryptodev-2s cryptodev-2s requested review from a team as code owners January 7, 2025 13:39
Copy link
Contributor

github-actions bot commented Jan 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cryptodev-2s cryptodev-2s requested a review from dan437 January 7, 2025 13:40
@cryptodev-2s cryptodev-2s self-assigned this Jan 7, 2025
@cryptodev-2s cryptodev-2s added the No QA Needed Apply this label when your PR does not need any QA effort. label Jan 7, 2025
@cryptodev-2s cryptodev-2s force-pushed the cryptodev2s/fix-smart-transactions-controller-messenger branch 2 times, most recently from ad50bb8 to 5c88b84 Compare January 7, 2025 13:46
@cryptodev-2s cryptodev-2s force-pushed the cryptodev2s/fix-smart-transactions-controller-messenger branch from 5c88b84 to 33d1348 Compare January 7, 2025 13:48
@cryptodev-2s cryptodev-2s added No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Jan 7, 2025
@Gudahtt
Copy link
Member

Gudahtt commented Jan 7, 2025

Does this fix a bug? And does this address a problem in a recent PR?

Copy link

sonarqubecloud bot commented Jan 7, 2025

@cryptodev-2s
Copy link
Contributor Author

cryptodev-2s commented Jan 7, 2025

Does this fix a bug? And does this address a problem in a recent PR?

Yes this fixes a bug in smart transaction publish hook, falling back to regular transaction submission
Error: Action missing from allow list: NetworkController:getState (reported by @dan437 )

For reference MetaMask/metamask-extension#29473

@cryptodev-2s cryptodev-2s enabled auto-merge January 7, 2025 14:43
@Gudahtt
Copy link
Member

Gudahtt commented Jan 7, 2025

Could you please create a GitHub issue for the bug on each platform? Or link it if it already exists.

@cryptodev-2s cryptodev-2s added No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed If the PR does not need E2E smoke test run and removed No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed If the PR does not need E2E smoke test run labels Jan 7, 2025
@cryptodev-2s cryptodev-2s added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 5a88fca Jan 9, 2025
63 checks passed
@cryptodev-2s cryptodev-2s deleted the cryptodev2s/fix-smart-transactions-controller-messenger branch January 9, 2025 12:40
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.40.0 Issue or pull request that will be included in release 7.40.0 team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Smart transaction publish hook, falling back to regular transaction submission
5 participants