Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(12849): alert toast blocking tab navigation #12853

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

vinnyhoward
Copy link
Contributor

Description

We have received several complaints about our toast blocking our tab navigation slowing down user experience

Related issues

Fixes: #12849

Manual testing steps

  1. On the wallet home page, click on the network selector on the top left
  2. Click on any network
  3. The toast should pop up

Screenshots/Recordings

Android

Before After
before after

iOS

Before After
before after

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinnyhoward vinnyhoward added team-design-system All issues relating to design system in Mobile Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux labels Jan 7, 2025
@vinnyhoward vinnyhoward requested a review from a team as a code owner January 7, 2025 23:47
Copy link
Contributor

github-actions bot commented Jan 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d258947
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/058ffac5-d779-48e7-873a-581bb1985a29

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@brianacnguyen brianacnguyen added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit 8dc1c9f Jan 8, 2025
47 of 48 checks passed
@brianacnguyen brianacnguyen deleted the fix-12849-alert-blocking-tab-nav branch January 8, 2025 16:17
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.40.0 Issue or pull request that will be included in release 7.40.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-design-system All issues relating to design system in Mobile team-wallet-ux
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Alerts blocks tab navigation
3 participants