Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix field name for PacketsTotal #125449

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yusufozturk
Copy link
Contributor

Total packets field name is "PacketsTotal". BytesTotal is a mistake.

Additionally, as a user, I must admit that BytesTotal, PacketsTotal, BytesReceived, BytesSent, PacketsReceived, PacketsSents fields are not clear for me.

There is no reference about these fields. Are they from CEF? Are they from CommonSecurityLog?

CommonSecurityLog field names are "ReceivedBytes" or "SentBytes".
CEF field names are "in" and "out".

Maybe they should be as SrcBytes and DstBytes?

This is really confusing. I will create an issue for this.

Total packets field name is "PacketsTotal". BytesTotal is a mistake.
Copy link
Contributor

@yusufozturk : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit e857702:

✅ Validation status: passed

File Status Preview URL Details
articles/sentinel/normalization-schema-network.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@yusufozturk
Copy link
Contributor Author

Adding @yelevin to the topic. Changes are coming from v1 documentation:
d002e78

I think field name should be "PacketsTotal" but how about other fields? I suspect that they might be also wrong because I can't find any reference about them. Thank you.

@v-dirichards
Copy link
Contributor

@oshezaf @yelevin

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants