Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: the big dependency bump #432

Closed
wants to merge 2 commits into from
Closed

Chore: the big dependency bump #432

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d66af1
fix: remove incorrect ConstantThreshold from UnivariateDriftCalculato…
josecaloca Sep 25, 2024
c6d326e
Merge pull request #425 from josecaloca/patch-1
nnansters Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions nannyml/drift/univariate/calculator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,10 @@ def __init__(

{
'kolmogorov_smirnov': StandardDeviationThreshold(std_lower_multiplier=None),
'jensen_shannon': ConstantThreshold(upper=0.1),
'jensen_shannon': StandardDeviationThreshold(std_lower_multiplier=None),
'wasserstein': StandardDeviationThreshold(std_lower_multiplier=None),
'hellinger': ConstantThreshold(upper=0.1),
'l_infinity': ConstantThreshold(upper=0.1)
'hellinger': StandardDeviationThreshold(std_lower_multiplier=None),
'l_infinity': StandardDeviationThreshold(std_lower_multiplier=None),
}

A dictionary allowing users to set a custom threshold for each method. It links a `Threshold` subclass
Expand All @@ -130,10 +130,10 @@ def __init__(
will be applied. The default method thresholds are as follows:

- `kolmogorov_smirnov`: `StandardDeviationThreshold(std_lower_multiplier=None)`
- `jensen_shannon`: `ConstantThreshold(upper=0.1)`
- `jensen_shannon`: `StandardDeviationThreshold(std_lower_multiplier=None)`
- `wasserstein`: `StandardDeviationThreshold(std_lower_multiplier=None)`
- `hellinger`: `ConstantThreshold(upper=0.1)`
- `l_infinity`: `ConstantThreshold(upper=0.1)`
- `hellinger`: `StandardDeviationThreshold(std_lower_multiplier=None)`
- `l_infinity`: `StandardDeviationThreshold(std_lower_multiplier=None)`

The `chi2` method does not support custom thresholds for now. Additional research is required to determine
how to transition from its current p-value based implementation.
Expand Down
Loading