Lockscreen: Separate 'Allow RPC While Locked' for USB/Bluetooth (BLE) #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Next-Flip#330, split of the `allow_locked_rpc_commands` bool into `allow_locked_rpc_usb` and `allow_locked_rpc_ble` to allow the connections separately.
956MB
requested review from
Willy-JL,
Sil333033,
HaxSam and
MatthewKuKanich
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Addresses #330.
Pretty simple change of the
allow_locked_rpc_commandssetting to allow the RPC connections of USB and Bluetooth separately.Screenshot
I put the "(USB)" and "(BLE)" at the beginning of the line because I felt having it all the way at the end of "Allow RPC While Locked" wouldn't look as good with them next to each other. It'd look like a bug at first with two of the same settings kinda.
For the reviewer