Asset Packs: Warning for RAM usage #344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Checks asset packs if they contain Fonts/Icons and adds "Size Warning" list entry that opens new scenes. - First scene is just a warning with text explaining that fonts and icons remain loaded and use up memory. - Second scene uses the file list widget to display all the selected asset packs fonts and icons, as well as their sizes. This information is just about being extra informative. No actions can be done on any of the files shown.
956MB
requested review from
Willy-JL,
Sil333033,
HaxSam and
MatthewKuKanich
as code owners
956MB
added a commit
to 956MB/Momentum-Firmware
that referenced
this pull request
Jan 5, 2025
|
Aligned the text to the center to improve the look and closer match other screens like "Enable Debug?".
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Asset Packs: Warning for packs that contain icons and fonts for RAM usage
Checks asset packs if they contain Fonts and/or Icons and adds "Size Warning" list entry, as well as a warning screen describing the ram usage of font/icons in the selected pack, and an info list of all the sizes of the files in the pack.
The information in the info screen is just about being extra informative. No actions can be done on any of the files shown.
Screenshots
Packs without fonts/icons, all is normal
'Size Warning' entry added to the list in
MNTM > Interface > GraphicsWarning screen (optional 'Back' button to just not look at the size info)
Size info for all font/icon files
For the reviewer