Fix MapItem incorectly fetching water biomes on treasure maps #11936
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a slight deviation from vanilla in that we incorrectly use the x/y/z coordinates rather than passing section coords. This is because the old method (getBiome) uses block coords, while uncached noise uses the section positions.
Warriorrrr
reviewed
Jan 9, 2025
| @@ -16,7 +16,7 @@ | |||
| for (int i5 = 0; i5 < 128; i5++) { | |||
| for (int i6 = 0; i6 < 128; i6++) { | |||
| - Holder<Biome> biome = serverLevel.getBiome(mutableBlockPos.set((i3 + i6) * i, 0, (i4 + i5) * i)); | |||
| + Holder<Biome> biome = serverLevel.getUncachedNoiseBiome((i3 + i6) * i, 0, (i4 + i5) * i); // Paper - Perf: Use seed based lookup for treasure maps | |||
| + Holder<Biome> biome = serverLevel.getUncachedNoiseBiome(net.minecraft.core.QuartPos.fromBlock((i3 + i6) * i), net.minecraft.core.QuartPos.fromBlock(0), net.minecraft.core.QuartPos.fromBlock((i4 + i5) * i)); // Paper - Perf: Use seed based lookup for treasure maps | |||
There was a problem hiding this comment.
fromBlock(0) could just be left as 0
There was a problem hiding this comment.
Did that for just logic consistency-- it shouldn't really matter.
Warriorrrr
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a slight deviation from vanilla in that we incorrectly use the x/y/z coordinates rather than passing section coords.
This is because the old method (getBiome) uses block coords, while uncached noise uses the section positions.
This whole "optimization" creates a big enough deviation in that it probably isn't noticeable. So maybe in future, this should be made configurable?
Note: This is an old issue, not hardfork issue.