Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: clean old files #72

Merged
merged 1 commit into from
Jan 5, 2024
Merged

ref: clean old files #72

merged 1 commit into from
Jan 5, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Jan 5, 2024

💡 Motivation and Context

Release log:

Total compressed archive size: 85 KB.
Validating package...
Package validation found the following potential issue:

  • 2 checked-in files are ignored by a .gitignore.
    Previous versions of Pub would include those in the published package.

    Consider adjusting your .gitignore files to not ignore those files, and if you do not wish to
    publish these files use .pubignore. See also dart.dev/go/pubignore

    Files that are checked in while gitignored:

    example/android/app/src/debug/AndroidManifest.xml
    example/ios/Podfile.lock

They don't need to be checked in.
Strange enough, example/android/app/src/debug/AndroidManifest.xml isn't ignored and has to be checked in, likely a bug in the analyzer.

#skip-changelog

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@@ -38,10 +38,6 @@ app.*.symbols
# Obfuscation related
app.*.map.json

# Android Studio will place build artifacts here
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its always build/ and its already ignored, likely an old gitignore file

@@ -1,29 +0,0 @@
PODS:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is auto generated anyways

@marandaneto marandaneto requested a review from a team January 5, 2024 12:42
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@marandaneto marandaneto merged commit d777ad1 into main Jan 5, 2024
5 checks passed
@marandaneto marandaneto deleted the ref/clean-old-files branch January 5, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants