fix(types): update unevaluatedItems type defintion #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4b93b0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tatomyr
approved these changes
Oct 13, 2023
tatomyr
force-pushed
the
fix/unevaluatedItems-type-def
branch
from
afc33d1 to
cc000a4
Compare
|
Hi @jeremyfiel! Thanks for your contribution. Could you add the patch changeset? Here's the guide: https://github.com/Redocly/redocly-cli/blob/main/.github/CONTRIBUTING.md#pull-request-guidelines |
jeremyfiel
force-pushed
the
fix/unevaluatedItems-type-def
branch
from
cc000a4 to
c961d6e
Compare
tatomyr
reviewed
Oct 13, 2023
tatomyr
reviewed
Oct 13, 2023
Per JSON Schema 2019-09+ spec. this annotation keyword can be any valid JSON Schema schema. e.g. `boolean` or `schema` https://json-schema.org/draft/2019-09/json-schema-core#unevaluatedItems partially fixes Redocly#1233
tatomyr
force-pushed
the
fix/unevaluatedItems-type-def
branch
from
7bfee4b to
4b93b0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per JSON Schema 2019-09+ spec. this annotation keyword can be any valid JSON Schema schema. e.g.
booleanorschemahttps://json-schema.org/draft/2019-09/json-schema-core#unevaluatedItemspartially fixes #1233
What/Why/How?
The type definition for
unevaulatedItemswas incorrect per the JSON Schema 2019-09 specificationReference
https://json-schema.org/draft/2019-09/json-schema-core#unevaluatedItems
Testing
Screenshots (optional)
Check yourself
Security