Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nr2.0: Resolve Self inside impl blocks #3359

Merged
merged 1 commit into from
Jan 8, 2025
Merged

nr2.0: Resolve Self inside impl blocks #3359

merged 1 commit into from
Jan 8, 2025
+28 −3

Conversation

powerboat9
Copy link
Contributor

No description provided.

@powerboat9
nr2.0: Resolve Self inside impl blocks
7566092 
gcc/rust/ChangeLog:

	* resolve/rust-toplevel-name-resolver-2.0.cc
	(TopLevel::visit): Insert a definition for Self when visiting
	InherentImpl and TraitImpl instances.
	* resolve/rust-toplevel-name-resolver-2.0.h
	(TopLevel::visit): Add visitors for InherentImpl and TraitImpl.

gcc/testsuite/ChangeLog:

	* rust/compile/nr2/exclude: Remove entries.

Signed-off-by: Owen Avery <[email protected]>
CohenArthur
CohenArthur approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, that's a nice trick! LGTM!

@CohenArthur CohenArthur added this pull request to the merge queue Jan 8, 2025
Merged via the queue into Rust-GCC:master with commit 1eaf085 Jan 8, 2025
12 checks passed
@powerboat9 powerboat9 deleted the fix-impl branch January 8, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CohenArthur CohenArthur CohenArthur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@powerboat9 @CohenArthur