Updated RxSwift to 6.0 and ios.deployment_target #102
Conversation
|
@jdisho you're listed as the current owner on the project, care to review and cut a new release? Thanks @Loupehope ! |
There was a problem hiding this comment.
Thanks for your work @Loupehope 😊
However, this PR contains work that IMO it should be addressed in separate PRs. I would appreciate if you can leave only the work about RxSwift 6.0 here and open new PRs about the code indentation part and the #98.
| let keyboardWillHide = UIResponder.keyboardWillHideNotification | ||
| let keyboardFrameEndKey = UIResponder.keyboardFrameEndUserInfoKey | ||
| let applicationDidFinishLaunching = UIApplication.didFinishLaunchingNotification | ||
| #else |
There was a problem hiding this comment.
Is this change intentional? Why should we drop support for versions lower than 4.2?
There was a problem hiding this comment.
In .podspec and package.swift files swift 5.0 is listed as minimal supported version, isn't it?
|
The CI keeps failing. Mind having a look? 😊 |
Well, I tried to fix the crash on CI: |
RxKeyboard.podspec
Outdated
| s.summary = 'Reactive Keyboard in iOS' | ||
| s.homepage = 'https://github.com/RxSwiftCommunity/RxKeyboard' | ||
| s.license = { :type => 'MIT', :file => 'LICENSE' } | ||
| s.author = { 'Suyeol Jeon' => '[email protected]' } | ||
| s.source = { :git => 'https://github.com/RxSwiftCommunity/RxKeyboard.git', | ||
| :tag => s.version.to_s } | ||
| s.source_files = 'Sources/**/*.swift' | ||
| s.frameworks = 'UIKit', 'Foundation' | ||
| s.frameworks = 'UIKit' | ||
| s.requires_arc = true | ||
| s.swift_version = "5.0" |
There was a problem hiding this comment.
Since RxSwift's Swift version is 5.1, I think this needs to reflected too.
|
We would appreciate your help @freak4pc regarding the CI 😊 |
Updated: