-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphMakie docs update #1130
base: master
Are you sure you want to change the base?
GraphMakie docs update #1130
Conversation
You need to also update all the places in the current docs where we show graphs to use the new code (preferably dynamically). |
GLMakie tests are failing? |
seems something GLFW-related, happening in the docs build too. Will probably debug tomorrow |
ok |
Seems like somehow the |
seems like it was because GLMakie is loaded in that |
Let's see how these look. I need to think about how to reduce the amount of whitespace though. I think it should do a bit better with |
Removed most of the GLMakie instances in the docs but there's still a |
There shouldn't be in an |
(I removed all GLMakie doc dependencies last week I thought.) |
Check the last two commits, I changed a couple instances there? But let me know if I did something wrong |
@vyudu looks like there are some text tweaks needed for the new colors / removal of labels, then this should be good. |
Looks like there is a bad link in one of the new doc files? |
Oh, this needs to also remove this stuff in Catalyst.jl that loads the GraphViz.jll: Lines 63 to 74 in b7d8c61
|
Hmm I can't find the new bad link, it's supposedly in api.md but I don't see a |
Is it linked via a docstring? |
Ah I see. But in that case I don't know why it's resolving to Main or CatalystGraphMakieExtension and not looking in Catalyst. |
docs/src/api.md
Outdated
Catalyst.ReactionComplexElement | ||
Catalyst.ReactionComplex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked completely fine before (for example, the current docs). Why would this be the underlying issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm yeah this doesn't make sense. But I don't understand what could cause the error it raises otherwise, will keep looking.
Update docs and drop Graphviz dependency. Ran into an issue on my machine where
ExpandTemplates
was hanging for a really long time, so I changed some of the@example
blocks to just ```julia, but it was still sort of hanging on the machine so not sure what's happening. In any case wanted to see how it did on the CI.