Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cf-units] Sorted pyproject.toml #530

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

ukmo-ccbunney
Copy link
Contributor

🚀 Pull Request

Description

Used sort-toml utility with some minor manual changes afterwards to preserve grouping of elements in arrays.

This should results in all sections and keys being sorted alphabetically.

Order of array elements has not been changed.

Use sort-toml utility with some minor manual changes afterwards to
preserve grouping of elements in arrays.
@ukmo-ccbunney ukmo-ccbunney requested a review from pp-mo November 22, 2024 14:29
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.40%. Comparing base (cb38821) to head (13ddeb6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #530   +/-   ##
=======================================
  Coverage   58.40%   58.40%           
=======================================
  Files          62       62           
  Lines        6433     6433           
  Branches     1150     1150           
=======================================
  Hits         3757     3757           
  Misses       2385     2385           
  Partials      291      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is all OK,
but can we not also adopt the sorting operation within the pre-commit ?

@ukmo-ccbunney
Copy link
Contributor Author

I guess this is all OK, but can we not also adopt the sorting operation within the pre-commit ?

I didn't adopt anything in the pre-commit as this was one of the outstanding questions from the sprint (what sorting tool we should adopt).

@pp-mo pp-mo merged commit 1d709d3 into SciTools:main Dec 10, 2024
16 checks passed
@ukmo-ccbunney ukmo-ccbunney deleted the pyproject_sorted branch December 10, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants