Skip to content

Commit

Permalink
Update tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@markmur
markmur committed Dec 17, 2024
1 parent c5bc2cc commit a1f0372
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 81 deletions.
2 changes: 2 additions & 0 deletions lib/src/main/java/com/shopify/checkoutsheetkit/CheckoutEventProcessor.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,8 @@ public abstract class DefaultCheckoutEventProcessor @JvmOverloads constructor(
context.checkSelfPermission(permission) == PackageManager.PERMISSION_GRANTED
}

println("hasRuntimePermission: ${hasRuntimePermission}",)

callback.invoke(origin, hasRuntimePermission, hasRuntimePermission)
}

Expand Down
117 changes: 36 additions & 81 deletions lib/src/test/java/com/shopify/checkoutsheetkit/DefaultCheckoutEventProcessorTest.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,13 @@ import android.net.Uri
import android.webkit.GeolocationPermissions
import androidx.activity.ComponentActivity
import com.shopify.checkoutsheetkit.lifecycleevents.CheckoutCompletedEvent
import com.shopify.checkoutsheetkit.pixelevents.PixelEvent
import org.assertj.core.api.Assertions.assertThat
import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.mockito.Mockito.`when`
import org.mockito.MockitoAnnotations
import org.mockito.kotlin.*
import org.mockito.Mockito.mock
import org.mockito.Mockito.verify
import org.mockito.kotlin.whenever
import org.robolectric.Robolectric
import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment
Expand All @@ -53,18 +52,16 @@ class DefaultCheckoutEventProcessorTest {
private lateinit var activity: ComponentActivity
private lateinit var shadowActivity: ShadowActivity
private val mockCallback = mock<GeolocationPermissions.Callback>()
private lateinit var processor: TestCheckoutEventProcessor
private lateinit var packageManager: PackageManager

@Before
fun setUp() {
MockitoAnnotations.openMocks(this)
activity = Robolectric.buildActivity(ComponentActivity::class.java).get()
shadowActivity = shadowOf(activity)
context = mock()
packageManager = mock()
`when`(context.packageManager).thenReturn(packageManager)
processor = TestCheckoutEventProcessor(context)
whenever(context.packageManager).thenReturn(packageManager)
whenever(context.packageName).thenReturn("com.test.package")
}

@Test
Expand All @@ -81,10 +78,9 @@ class DefaultCheckoutEventProcessorTest {

@Test
fun `onCheckoutLinkClicked with mailto scheme launches email intent with to address`() {
val processor = processor(activity)
val uri = Uri.parse("mailto:[email protected]")

processor.onCheckoutLinkClicked(uri)
processor(activity).onCheckoutLinkClicked(uri)

val intent = shadowActivity.peekNextStartedActivityForResult().intent
assertThat(intent.getStringArrayExtra(Intent.EXTRA_EMAIL))
Expand All @@ -94,10 +90,9 @@ class DefaultCheckoutEventProcessorTest {

@Test
fun `onCheckoutLinkClicked with tel scheme launches action dial intent with phone number`() {
val processor = processor(activity)
val uri = Uri.parse("tel:0123456789")

processor.onCheckoutLinkClicked(uri)
processor(activity).onCheckoutLinkClicked(uri)

val intent = shadowActivity.peekNextStartedActivityForResult().intent
assertThat(intent.data).isEqualTo(uri)
Expand All @@ -116,25 +111,7 @@ class DefaultCheckoutEventProcessorTest {
val shadowPackageManager = shadowOf(pm)
shadowPackageManager.addResolveInfoForIntent(expectedIntent, ResolveInfo())

val processor =
object : DefaultCheckoutEventProcessor(activity, log) {
override fun onCheckoutCompleted(
checkoutCompletedEvent: CheckoutCompletedEvent
) {
/* not implemented */
}
override fun onCheckoutFailed(error: CheckoutException) {
/* not implemented */
}
override fun onCheckoutCanceled() {
/* not implemented */
}
override fun onWebPixelEvent(event: PixelEvent) {
/* not implemented */
}
}

processor.onCheckoutLinkClicked(uri)
processor(activity, log).onCheckoutLinkClicked(uri)

val intent = shadowActivity.peekNextStartedActivityForResult().intent
assertThat(intent.data).isEqualTo(uri)
Expand All @@ -144,27 +121,9 @@ class DefaultCheckoutEventProcessorTest {
@Test
fun `onCheckoutLinkedClick with unhandled scheme logs warning`() {
val log = mock<LogWrapper>()
val processor =
object : DefaultCheckoutEventProcessor(activity, log) {
override fun onCheckoutCompleted(
checkoutCompletedEvent: CheckoutCompletedEvent
) {
/* not implemented */
}
override fun onCheckoutFailed(error: CheckoutException) {
/* not implemented */
}
override fun onCheckoutCanceled() {
/* not implemented */
}
override fun onWebPixelEvent(event: PixelEvent) {
/* not implemented */
}
}

val uri = Uri.parse("ftp:random")

processor.onCheckoutLinkClicked(uri)
processor(activity, log).onCheckoutLinkClicked(uri)

assertThat(shadowActivity.peekNextStartedActivityForResult()).isNull()
verify(log)
Expand All @@ -180,23 +139,11 @@ class DefaultCheckoutEventProcessorTest {
var description = ""
var recoverable: Boolean? = null
val processor =
object : DefaultCheckoutEventProcessor(activity, log) {
override fun onCheckoutCompleted(
checkoutCompletedEvent: CheckoutCompletedEvent
) {
/* not implemented */
}
object : TestCheckoutEventProcessor(activity, log) {
override fun onCheckoutFailed(error: CheckoutException) {
description = error.errorDescription
recoverable = error.isRecoverable
}
override fun onCheckoutCanceled() {
/* not implemented */
}

override fun onWebPixelEvent(event: PixelEvent) {
/* not implemented */
}
}

val error = object : CheckoutUnavailableException("error description", "unknown", true) {}
Expand All @@ -208,16 +155,16 @@ class DefaultCheckoutEventProcessorTest {
}

@Test
fun testOnGeolocationPermissionsShowPrompt_withNoManifestPermission() {
fun `invokes the callback with false for grant and retain arguments`() {
// Simulate no permissions declared in the manifest
whenever(packageManager.getPackageInfo(context.packageName, PackageManager.GET_PERMISSIONS))
.thenThrow(PackageManager.NameNotFoundException())
processor.onGeolocationPermissionsShowPrompt("http://shopify.com", mockCallback)
processor(activity).onGeolocationPermissionsShowPrompt("http://shopify.com", mockCallback)
verify(mockCallback).invoke("http://shopify.com", false, false)
}

@Test
fun testOnGeolocationPermissionsShowPrompt_withManifestPermissionGranted() {
fun `invokes the callback with true for grant and retain arguments when included in the manifest`() {
// Simulate permissions declared in the manifest
val permissions =
arrayOf(
Expand All @@ -233,13 +180,14 @@ class DefaultCheckoutEventProcessorTest {
whenever(context.checkSelfPermission(Manifest.permission.ACCESS_COARSE_LOCATION))
.thenReturn(PackageManager.PERMISSION_GRANTED)

processor.onGeolocationPermissionsShowPrompt("http://shopify.com", mockCallback)
TestCheckoutEventProcessor(context)
.onGeolocationPermissionsShowPrompt("http://shopify.com", mockCallback)

verify(mockCallback).invoke("http://shopify.com", true, true)
}

@Test
fun testOnGeolocationPermissionsShowPrompt_withManifestPermissionDenied() {
fun `invokes the callback with false for grant and retain arguments when not included in the manifest`() {
// Simulate permissions declared in the manifest
val permissions =
arrayOf(
Expand All @@ -255,30 +203,37 @@ class DefaultCheckoutEventProcessorTest {
whenever(context.checkSelfPermission(Manifest.permission.ACCESS_COARSE_LOCATION))
.thenReturn(PackageManager.PERMISSION_DENIED)

processor.onGeolocationPermissionsShowPrompt("http://shopify.com", mockCallback)
TestCheckoutEventProcessor(context)
.onGeolocationPermissionsShowPrompt("http://shopify.com", mockCallback)

verify(mockCallback).invoke("http://shopify.com", false, false)
}

// Private

private fun processor(activity: ComponentActivity): DefaultCheckoutEventProcessor {
return object : DefaultCheckoutEventProcessor(activity) {
override fun onCheckoutCompleted(checkoutCompletedEvent: CheckoutCompletedEvent) {}
override fun onCheckoutFailed(error: CheckoutException) {}
override fun onCheckoutCanceled() {}
override fun onWebPixelEvent(event: PixelEvent) {}
}
private fun processor(
activity: ComponentActivity,
log: LogWrapper = LogWrapper()
): DefaultCheckoutEventProcessor {
return object : TestCheckoutEventProcessor(activity, log) {}
}

private fun mockPackageInfo(permissions: Array<String>): PackageInfo {
return PackageInfo().apply { requestedPermissions = permissions }
}

private class TestCheckoutEventProcessor(context: Context) :
DefaultCheckoutEventProcessor(context) {
override fun onCheckoutCompleted(checkoutCompletedEvent: CheckoutCompletedEvent) {}
override fun onCheckoutFailed(error: CheckoutException) {}
override fun onCheckoutCanceled() {}
private open class TestCheckoutEventProcessor(
context: Context,
log: LogWrapper = LogWrapper()
) : DefaultCheckoutEventProcessor(context, log) {
override fun onCheckoutCompleted(checkoutCompletedEvent: CheckoutCompletedEvent) {
/*noop*/
}
override fun onCheckoutFailed(error: CheckoutException) {
/*noop*/
}
override fun onCheckoutCanceled() {
/*noop*/
}
}
}

0 comments on commit a1f0372

Please sign in to comment.