Allow selecting different variant options, respect available for sale #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiftio
commented
Jan 2, 2025
| @@ -95,6 +96,7 @@ fun CartItem( | |||
| style = MaterialTheme.typography.bodySmall, | |||
| color = MaterialTheme.colorScheme.secondary, | |||
| ) | |||
| BodySmall(cartLine.variantDescription) | |||
There was a problem hiding this comment.
display selected options on the cart page
There was a problem hiding this comment.
What happens with products without variantDescription?
edit:
nvm, it's a non-nullable attribute
kiftio
commented
Jan 2, 2025
| MoneyText( | ||
| currency = product.priceRange.maxVariantPrice.currencyCode, | ||
| price = product.priceRange.maxVariantPrice.amount, | ||
| MoneyRangeText( |
There was a problem hiding this comment.
this should be a range for products with differently priced variants
kiftio
commented
Jan 2, 2025
| } | ||
|
|
||
| QuantitySelector(enabled = true, quantity = productUIState.addQuantityAmount) { quantity -> | ||
| productViewModel.setAddQuantityAmount(quantity) | ||
| } | ||
|
|
||
| AddToCartButton( | ||
| enabled = productUIState.selectedVariant.availableForSale, |
There was a problem hiding this comment.
disable add to cart if the selected variant is not available for sale
kiftio
commented
Jan 2, 2025
| @@ -52,14 +52,14 @@ class ProductRepository( | |||
| if (products == null) { | |||
| continuation.resumeWith(Result.failure(RuntimeException("Failed to fetch products"))) | |||
| } else { | |||
| val products = Products( | |||
| val result = Products( | |||
There was a problem hiding this comment.
small fix for the var name products being shadowed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Allow selecting different variant options, respect available for sale
How to test
I've added variants to the cat palm product in the checkout store for testing
variants.mp4
Before you merge
Important
Checklist for releasing a new version
build.gradlefileTip
See the Contributing documentation for instructions on how to publish a new version of the library.